You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/17 14:18:43 UTC
[GitHub] [spark] beliefer opened a new pull request #32212: [SPARK-35116] The generated data fits the precision of DayTimeIntervalType in spark
beliefer opened a new pull request #32212:
URL: https://github.com/apache/spark/pull/32212
### What changes were proposed in this pull request?
The precision of `java.time.Duration` is nanosecond, but when it is used as `DayTimeIntervalType` in Spark, it is microsecond.
At present, the `DayTimeIntervalType` data generated in the implementation of `RandomDataGenerator` is accurate to nanosecond, which will cause the `DayTimeIntervalType` to be converted to long, and then back to `DayTimeIntervalType` to lose the accuracy, which will cause the test to fail. For example: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137390/testReport/org.apache.spark.sql.hive.execution/HashAggregationQueryWithControlledFallbackSuite/udaf_with_all_data_types/
### Why are the changes needed?
Improve `RandomDataGenerator` so that the generated data fits the precision of DayTimeIntervalType in spark.
### Does this PR introduce _any_ user-facing change?
'No'. Just change the test class.
### How was this patch tested?
Jenkins test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32212: [SPARK-35116][SQL][TESTS] The generated data fits the precision of DayTimeIntervalType in spark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32212:
URL: https://github.com/apache/spark/pull/32212#issuecomment-821920551
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42090/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32212: [SPARK-35116] The generated data fits the precision of DayTimeIntervalType in spark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32212:
URL: https://github.com/apache/spark/pull/32212#issuecomment-821877885
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137506/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32212: [SPARK-35116][SQL][TESTS] The generated data fits the precision of DayTimeIntervalType in spark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32212:
URL: https://github.com/apache/spark/pull/32212#issuecomment-821921500
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42090/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #32212: [SPARK-35116][SQL][TESTS] The generated data fits the precision of DayTimeIntervalType in spark
Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #32212:
URL: https://github.com/apache/spark/pull/32212#issuecomment-821943244
@MaxGekk Thanks for your review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32212: [SPARK-35116] The generated data fits the precision of DayTimeIntervalType in spark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32212:
URL: https://github.com/apache/spark/pull/32212#issuecomment-821842906
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42080/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32212: [SPARK-35116] The generated data fits the precision of DayTimeIntervalType in spark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32212:
URL: https://github.com/apache/spark/pull/32212#issuecomment-821843649
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42080/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32212: [SPARK-35116][SQL][TESTS] The generated data fits the precision of DayTimeIntervalType in spark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32212:
URL: https://github.com/apache/spark/pull/32212#issuecomment-821916024
**[Test build #137516 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137516/testReport)** for PR 32212 at commit [`e28601f`](https://github.com/apache/spark/commit/e28601f4ac03af101619f471026f16d25eace4da).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32212: [SPARK-35116][SQL][TESTS] The generated data fits the precision of DayTimeIntervalType in spark
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32212:
URL: https://github.com/apache/spark/pull/32212#issuecomment-821916024
**[Test build #137516 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137516/testReport)** for PR 32212 at commit [`e28601f`](https://github.com/apache/spark/commit/e28601f4ac03af101619f471026f16d25eace4da).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #32212: [SPARK-35116][SQL][TESTS] The generated data fits the precision of DayTimeIntervalType in spark
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #32212:
URL: https://github.com/apache/spark/pull/32212
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #32212: [SPARK-35116] The generated data fits the precision of DayTimeIntervalType in spark
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #32212:
URL: https://github.com/apache/spark/pull/32212#discussion_r615272032
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/RandomDataGenerator.scala
##########
@@ -275,8 +275,13 @@ object RandomDataGenerator {
case DayTimeIntervalType => Some(() => {
val maxSeconds = Duration.ofDays(106751991).getSeconds
val seconds = rand.nextLong() % maxSeconds
+ // The precision of java.time.Duration is nanosecond, but when it is used as
+ // DayTimeIntervalType in Spark, it is microsecond. Here by following the behavior
+ // of DurationConverter to achieve consistency
val nanoAdjustment = rand.nextLong() % 999999000
- Duration.ofSeconds(seconds, nanoAdjustment)
+ val duration = Duration.ofSeconds(seconds, nanoAdjustment)
+ val micros = IntervalUtils.durationToMicros(duration)
+ IntervalUtils.microsToDuration(micros)
})
Review comment:
I think we can simplify the code:
```scala
case DayTimeIntervalType => Some(() => Duration.of(rand.nextLong(), ChronoUnit.MICROS))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32212: [SPARK-35116][SQL][TESTS] The generated data fits the precision of DayTimeIntervalType in spark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32212:
URL: https://github.com/apache/spark/pull/32212#issuecomment-821920199
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42090/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #32212: [SPARK-35116] The generated data fits the precision of DayTimeIntervalType in spark
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #32212:
URL: https://github.com/apache/spark/pull/32212#discussion_r615325950
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/RandomDataGenerator.scala
##########
@@ -275,8 +275,13 @@ object RandomDataGenerator {
case DayTimeIntervalType => Some(() => {
val maxSeconds = Duration.ofDays(106751991).getSeconds
val seconds = rand.nextLong() % maxSeconds
+ // The precision of java.time.Duration is nanosecond, but when it is used as
+ // DayTimeIntervalType in Spark, it is microsecond. Here by following the behavior
+ // of DurationConverter to achieve consistency
val nanoAdjustment = rand.nextLong() % 999999000
- Duration.ofSeconds(seconds, nanoAdjustment)
+ val duration = Duration.ofSeconds(seconds, nanoAdjustment)
+ val micros = IntervalUtils.durationToMicros(duration)
+ IntervalUtils.microsToDuration(micros)
})
Review comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32212: [SPARK-35116][SQL][TESTS] The generated data fits the precision of DayTimeIntervalType in spark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32212:
URL: https://github.com/apache/spark/pull/32212#issuecomment-821941297
**[Test build #137516 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137516/testReport)** for PR 32212 at commit [`e28601f`](https://github.com/apache/spark/commit/e28601f4ac03af101619f471026f16d25eace4da).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32212: [SPARK-35116][SQL][TESTS] The generated data fits the precision of DayTimeIntervalType in spark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32212:
URL: https://github.com/apache/spark/pull/32212#issuecomment-821944236
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137516/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32212: [SPARK-35116][SQL][TESTS] The generated data fits the precision of DayTimeIntervalType in spark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32212:
URL: https://github.com/apache/spark/pull/32212#issuecomment-821921500
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42090/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32212: [SPARK-35116] The generated data fits the precision of DayTimeIntervalType in spark
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32212:
URL: https://github.com/apache/spark/pull/32212#issuecomment-821834845
**[Test build #137506 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137506/testReport)** for PR 32212 at commit [`0b7de13`](https://github.com/apache/spark/commit/0b7de13d2b6477df8682189fb66dc8f1fa3955be).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32212: [SPARK-35116] The generated data fits the precision of DayTimeIntervalType in spark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32212:
URL: https://github.com/apache/spark/pull/32212#issuecomment-821834845
**[Test build #137506 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137506/testReport)** for PR 32212 at commit [`0b7de13`](https://github.com/apache/spark/commit/0b7de13d2b6477df8682189fb66dc8f1fa3955be).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32212: [SPARK-35116] The generated data fits the precision of DayTimeIntervalType in spark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32212:
URL: https://github.com/apache/spark/pull/32212#issuecomment-821874467
**[Test build #137506 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137506/testReport)** for PR 32212 at commit [`0b7de13`](https://github.com/apache/spark/commit/0b7de13d2b6477df8682189fb66dc8f1fa3955be).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32212: [SPARK-35116][SQL][TESTS] The generated data fits the precision of DayTimeIntervalType in spark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32212:
URL: https://github.com/apache/spark/pull/32212#issuecomment-821944236
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137516/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #32212: [SPARK-35116] The generated data fits the precision of DayTimeIntervalType in spark
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #32212:
URL: https://github.com/apache/spark/pull/32212#issuecomment-821914105
**[Test build #759707876](https://github.com/beliefer/spark/actions/runs/759707876)** for PR 32212 at commit [`8201a77`](https://github.com/beliefer/spark/commit/8201a77091868c0ec7f5c25ee75ec171e1ce6cec).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32212: [SPARK-35116] The generated data fits the precision of DayTimeIntervalType in spark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32212:
URL: https://github.com/apache/spark/pull/32212#issuecomment-821843649
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42080/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #32212: [SPARK-35116] The generated data fits the precision of DayTimeIntervalType in spark
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #32212:
URL: https://github.com/apache/spark/pull/32212#discussion_r615272903
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/RandomDataGenerator.scala
##########
@@ -275,8 +275,13 @@ object RandomDataGenerator {
case DayTimeIntervalType => Some(() => {
val maxSeconds = Duration.ofDays(106751991).getSeconds
val seconds = rand.nextLong() % maxSeconds
+ // The precision of java.time.Duration is nanosecond, but when it is used as
+ // DayTimeIntervalType in Spark, it is microsecond. Here by following the behavior
+ // of DurationConverter to achieve consistency
val nanoAdjustment = rand.nextLong() % 999999000
- Duration.ofSeconds(seconds, nanoAdjustment)
+ val duration = Duration.ofSeconds(seconds, nanoAdjustment)
+ val micros = IntervalUtils.durationToMicros(duration)
+ IntervalUtils.microsToDuration(micros)
})
case YearMonthIntervalType => Some(() => {
Review comment:
The same here:
```scala
case YearMonthIntervalType => Some(() => Period.ofMonths(rand.nextInt()))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32212: [SPARK-35116] The generated data fits the precision of DayTimeIntervalType in spark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32212:
URL: https://github.com/apache/spark/pull/32212#issuecomment-821842264
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42080/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #32212: [SPARK-35116] The generated data fits the precision of DayTimeIntervalType in spark
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #32212:
URL: https://github.com/apache/spark/pull/32212#issuecomment-821915542
**[Test build #759729498](https://github.com/beliefer/spark/actions/runs/759729498)** for PR 32212 at commit [`e28601f`](https://github.com/beliefer/spark/commit/e28601f4ac03af101619f471026f16d25eace4da).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #32212: [SPARK-35116] The generated data fits the precision of DayTimeIntervalType in spark
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #32212:
URL: https://github.com/apache/spark/pull/32212#issuecomment-821829920
**[Test build #758636338](https://github.com/beliefer/spark/actions/runs/758636338)** for PR 32212 at commit [`0b7de13`](https://github.com/beliefer/spark/commit/0b7de13d2b6477df8682189fb66dc8f1fa3955be).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32212: [SPARK-35116] The generated data fits the precision of DayTimeIntervalType in spark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32212:
URL: https://github.com/apache/spark/pull/32212#issuecomment-821877885
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137506/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #32212: [SPARK-35116][SQL][TESTS] The generated data fits the precision of DayTimeIntervalType in spark
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #32212:
URL: https://github.com/apache/spark/pull/32212#issuecomment-821940024
+1, LGTM. GA passed. Merging to master.
Thank you, @beliefer .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org