[GitHub] [nuttx] patacongo commented on a diff in pull request #8843: drivers/serial: Always support c_oflag, c_iflag and c_lflag in termios

["patacongo (via GitHub)" <gi...@apache.org>]

patacongo commented on code in PR #8843:
URL: https://github.com/apache/nuttx/pull/8843#discussion_r1141418614


##########
drivers/usbdev/cdcacm.c:
##########
@@ -2339,9 +2339,6 @@ static int cdcuart_ioctl(FAR struct file *filep, int cmd, unsigned long arg)
 
         /* And update with flags from this layer */
 
-        termiosp->c_iflag = serdev->tc_iflag;
-        termiosp->c_oflag = serdev->tc_oflag;
-        termiosp->c_lflag = serdev->tc_lflag;

Review Comment:
   I am not sure I understand these three lines completely.  Is this because the values will be used in serial.c logic?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org