You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/11/19 05:25:14 UTC

[GitHub] [zookeeper] hanm commented on a change in pull request #1526: ZOOKEEPER-3874 Official API to start ZooKeeper server from Java

hanm commented on a change in pull request #1526:
URL: https://github.com/apache/zookeeper/pull/1526#discussion_r526601753



##########
File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java
##########
@@ -611,14 +611,16 @@ public void rollLog() throws IOException {
      * @throws IOException
      */
     public void close() throws IOException {

Review comment:
       what's the purpose of the changes to this `close` method? I don't quite get the motivation behind this change.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org