You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by David Radley <da...@uk.ibm.com> on 2017/06/27 09:04:39 UTC
Review Request 60457: ATLS-1899
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60457/
-----------------------------------------------------------
Review request for atlas and Madhan Neethiraj.
Repository: atlas
Description
-------
fixup the logic around edge creation for relationshipDefs
Diffs
-----
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipDefStoreV1.java 194c5461505b9400cf30d6bc4abebc2c9325c001
Diff: https://reviews.apache.org/r/60457/diff/1/
Testing
-------
ran junits
created a relationshipDef with different types and names
created a relationshipDef with ends contianing the same names and types.
checked the trace to see that it was as expected in both cases.
Thanks,
David Radley
Re: Review Request 60457: ATLS-1899
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60457/#review179467
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On June 27, 2017, 9:04 a.m., David Radley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60457/
> -----------------------------------------------------------
>
> (Updated June 27, 2017, 9:04 a.m.)
>
>
> Review request for atlas and Madhan Neethiraj.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> fixup the logic around edge creation for relationshipDefs
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipDefStoreV1.java 194c5461505b9400cf30d6bc4abebc2c9325c001
>
>
> Diff: https://reviews.apache.org/r/60457/diff/1/
>
>
> Testing
> -------
>
> ran junits
> created a relationshipDef with different types and names
> created a relationshipDef with ends contianing the same names and types.
>
> checked the trace to see that it was as expected in both cases.
>
>
> Thanks,
>
> David Radley
>
>