You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2017/10/04 15:48:15 UTC
Review Request 62774: Added a test
`ROOT_DOCKER_NoTransitionFromKillingToFinished`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62774/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar and Vinod Kone.
Bugs: MESOS-7975
https://issues.apache.org/jira/browse/MESOS-7975
Repository: mesos
Description
-------
Added a test `ROOT_DOCKER_NoTransitionFromKillingToFinished`.
Diffs
-----
src/tests/containerizer/docker_containerizer_tests.cpp 45f0d1dbc5b21b174cd9974664299d466129df01
Diff: https://reviews.apache.org/r/62774/diff/1/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 62774: Added a test
`ROOT_DOCKER_NoTransitionFromKillingToFinished`.
Posted by Qian Zhang <zh...@gmail.com>.
> On Nov. 2, 2017, 12:47 a.m., Gaston Kleiman wrote:
> > src/tests/containerizer/docker_containerizer_tests.cpp
> > Lines 4168-4169 (patched)
> > <https://reviews.apache.org/r/62774/diff/1/?file=1846111#file1846111line4168>
> >
> > I don't think this test passes now that the built-in executors send `TASK_STARTING` updates.
Sorry my bad, I have posted a patch (https://reviews.apache.org/r/63497/) to fix it.
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62774/#review189811
-----------------------------------------------------------
On Oct. 4, 2017, 11:48 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62774/
> -----------------------------------------------------------
>
> (Updated Oct. 4, 2017, 11:48 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Bugs: MESOS-7975
> https://issues.apache.org/jira/browse/MESOS-7975
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `ROOT_DOCKER_NoTransitionFromKillingToFinished`.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_containerizer_tests.cpp 45f0d1dbc5b21b174cd9974664299d466129df01
>
>
> Diff: https://reviews.apache.org/r/62774/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 62774: Added a test
`ROOT_DOCKER_NoTransitionFromKillingToFinished`.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62774/#review189811
-----------------------------------------------------------
src/tests/containerizer/docker_containerizer_tests.cpp
Lines 4168-4169 (patched)
<https://reviews.apache.org/r/62774/#comment267020>
I don't think this test passes now that the built-in executors send `TASK_STARTING` updates.
- Gaston Kleiman
On Oct. 4, 2017, 8:48 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62774/
> -----------------------------------------------------------
>
> (Updated Oct. 4, 2017, 8:48 a.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Bugs: MESOS-7975
> https://issues.apache.org/jira/browse/MESOS-7975
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `ROOT_DOCKER_NoTransitionFromKillingToFinished`.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_containerizer_tests.cpp 45f0d1dbc5b21b174cd9974664299d466129df01
>
>
> Diff: https://reviews.apache.org/r/62774/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 62774: Added a test
`ROOT_DOCKER_NoTransitionFromKillingToFinished`.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62774/#review187218
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Oct. 4, 2017, 3:48 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62774/
> -----------------------------------------------------------
>
> (Updated Oct. 4, 2017, 3:48 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Bugs: MESOS-7975
> https://issues.apache.org/jira/browse/MESOS-7975
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `ROOT_DOCKER_NoTransitionFromKillingToFinished`.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_containerizer_tests.cpp 45f0d1dbc5b21b174cd9974664299d466129df01
>
>
> Diff: https://reviews.apache.org/r/62774/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>