You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/06/06 12:46:15 UTC
[GitHub] [iceberg] findepi opened a new pull request, #4965: Fix :iceberg-api:revapi failure - allow the new method
findepi opened a new pull request, #4965:
URL: https://github.com/apache/iceberg/pull/4965
Before the change, a build run locally with
./gradlew -x test -x integrationTest clean build
would fail at the :iceberg-api:revapi task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #4965: Fix :iceberg-api:revapi failure - allow the new method
Posted by GitBox <gi...@apache.org>.
rdblue merged PR #4965:
URL: https://github.com/apache/iceberg/pull/4965
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] findepi commented on pull request #4965: Fix :iceberg-api:revapi failure - allow the new method
Posted by GitBox <gi...@apache.org>.
findepi commented on PR #4965:
URL: https://github.com/apache/iceberg/pull/4965#issuecomment-1147410805
> But better fix the CI task (github actions of rev api) to catch it before merging this?
Good idea, someone should look into that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] ajantha-bhat commented on pull request #4965: Fix :iceberg-api:revapi failure - allow the new method
Posted by GitBox <gi...@apache.org>.
ajantha-bhat commented on PR #4965:
URL: https://github.com/apache/iceberg/pull/4965#issuecomment-1147410375
@findepi : Thanks for the Fix. But better fix the CI task (github actions of rev api) to catch it before merging this? Else some other new PR might produce new issue and we keep on fixing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] findepi commented on pull request #4965: Fix :iceberg-api:revapi failure - allow the new method
Posted by GitBox <gi...@apache.org>.
findepi commented on PR #4965:
URL: https://github.com/apache/iceberg/pull/4965#issuecomment-1147410314
Per @ajantha-bhat 's comment https://apache-iceberg.slack.com/archives/C025PH0G1D4/p1654519428401729?thread_ts=1654517622.709609&cid=C025PH0G1D4, the `:iceberg-api:revapi` gets SKIPPED when run on `master branch from the `api-binary-compatibility.yml` workflow.
Example in currently last run on the master branch: https://github.com/apache/iceberg/runs/6747965003?check_suite_focus=true
perhaps same or similar problem applies to the PR builds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org