You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2021/07/14 14:04:21 UTC
[GitHub] [logging-log4j2] sman-81 opened a new pull request #549: LOG4J2-2955: More precise file size expression parsing; fail-fast behavior for invalid expressions
sman-81 opened a new pull request #549:
URL: https://github.com/apache/logging-log4j2/pull/549
…avior for invalid expressions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] rgoers commented on pull request #549: LOG4J2-2955: More precise file size expression parsing; fail-fast behavior for invalid expressions
Posted by GitBox <gi...@apache.org>.
rgoers commented on pull request #549:
URL: https://github.com/apache/logging-log4j2/pull/549#issuecomment-974873533
I started to apply this and got an error from revapi that compatibility had been broken. The previous version passed in a default value and used that if there was an error. This version throws an exception which will cause Appender initialization to fail. I think I prefer logging an error and using the default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] rgoers commented on pull request #549: LOG4J2-2955: More precise file size expression parsing; fail-fast behavior for invalid expressions
Posted by GitBox <gi...@apache.org>.
rgoers commented on pull request #549:
URL: https://github.com/apache/logging-log4j2/pull/549#issuecomment-974873533
I started to apply this and got an error from revapi that compatibility had been broken. The previous version passed in a default value and used that if there was an error. This version throws an exception which will cause Appender initialization to fail. I think I prefer logging an error and using the default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] rgoers commented on pull request #549: LOG4J2-2955: More precise file size expression parsing; fail-fast behavior for invalid expressions
Posted by GitBox <gi...@apache.org>.
rgoers commented on pull request #549:
URL: https://github.com/apache/logging-log4j2/pull/549#issuecomment-974920629
Part of the patch was applied.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] rgoers closed pull request #549: LOG4J2-2955: More precise file size expression parsing; fail-fast behavior for invalid expressions
Posted by GitBox <gi...@apache.org>.
rgoers closed pull request #549:
URL: https://github.com/apache/logging-log4j2/pull/549
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org