You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celix.apache.org by "PengZheng (via GitHub)" <gi...@apache.org> on 2023/09/19 05:28:44 UTC
[PR] Remove a check-then-act race condition. (celix)
PengZheng opened a new pull request, #645:
URL: https://github.com/apache/celix/pull/645
Checking whether a bundle is active in `celix_bundleContext_useBundles` callback suffers from check-then-act race condition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] hotfix/Remove a check-then-act race condition. (celix)
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #645:
URL: https://github.com/apache/celix/pull/645#issuecomment-1724856937
## [Codecov](https://app.codecov.io/gh/apache/celix/pull/645?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#645](https://app.codecov.io/gh/apache/celix/pull/645?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (beb910e) into [master](https://app.codecov.io/gh/apache/celix/commit/91ff81c54a59305d3684e64bcaf05b37b4da7dee?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (91ff81c) will **increase** coverage by `0.04%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #645 +/- ##
==========================================
+ Coverage 81.58% 81.63% +0.04%
==========================================
Files 260 260
Lines 34679 34678 -1
==========================================
+ Hits 28294 28309 +15
+ Misses 6385 6369 -16
```
| [Files Changed](https://app.codecov.io/gh/apache/celix/pull/645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [libs/framework/src/dm\_dependency\_manager\_impl.c](https://app.codecov.io/gh/apache/celix/pull/645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bGlicy9mcmFtZXdvcmsvc3JjL2RtX2RlcGVuZGVuY3lfbWFuYWdlcl9pbXBsLmM=) | `83.04% <100.00%> (+2.09%)` | :arrow_up: |
... and [4 files with indirect coverage changes](https://app.codecov.io/gh/apache/celix/pull/645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] hotfix/Remove a check-then-act race condition. (celix)
Posted by "PengZheng (via GitHub)" <gi...@apache.org>.
PengZheng commented on PR #645:
URL: https://github.com/apache/celix/pull/645#issuecomment-1724872583
This PR will manifest a deadlock in `test_components_ready`.
More investigation is needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org