You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Zhou wenjian (JIRA)" <ji...@apache.org> on 2012/08/27 05:08:07 UTC
[jira] [Created] (HBASE-6668) disable in shell may make confused
to user
Zhou wenjian created HBASE-6668:
-----------------------------------
Summary: disable in shell may make confused to user
Key: HBASE-6668
URL: https://issues.apache.org/jira/browse/HBASE-6668
Project: HBase
Issue Type: Bug
Components: shell
Affects Versions: 0.94.1
Reporter: Zhou wenjian
Assignee: Zhou wenjian
Fix For: 0.94.2
hbase(main):002:0> disable 'logTable'
0 row(s) in 2.0910 seconds
hbase(main):003:0> disable 'logTable'
0 row(s) in 0.0260 seconds
and we can found table are disabled in log when disable first appears
but when i disable it again the client just return seemed to be sucessful and I can not find any log described it in the log.
look into the admin.rb, find below
#----------------------------------------------------------------------------------------------
# Disables a table
def disable(table_name)
tableExists(table_name)
return if disabled?(table_name)
@admin.disableTable(table_name)
end
that would confuse us when we found it disabled already but returns nothing
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6668) disable in shell may make confused
to user
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-6668:
---------------------------------
Fix Version/s: (was: 0.94.3)
> disable in shell may make confused to user
> -------------------------------------------
>
> Key: HBASE-6668
> URL: https://issues.apache.org/jira/browse/HBASE-6668
> Project: HBase
> Issue Type: Bug
> Components: shell
> Affects Versions: 0.94.1
> Reporter: Zhou wenjian
> Assignee: Zhou wenjian
>
> hbase(main):002:0> disable 'logTable'
> 0 row(s) in 2.0910 seconds
> hbase(main):003:0> disable 'logTable'
> 0 row(s) in 0.0260 seconds
> and we can found table are disabled in log when disable first appears
> but when i disable it again the client just return seemed to be sucessful and I can not find any log described it in the log.
> look into the admin.rb, find below
> #----------------------------------------------------------------------------------------------
> # Disables a table
> def disable(table_name)
> tableExists(table_name)
> return if disabled?(table_name)
> @admin.disableTable(table_name)
> end
> that would confuse us when we found it disabled already but returns nothing
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6668) disable in shell may make confused
to user
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-6668:
---------------------------------
Fix Version/s: (was: 0.94.2)
0.94.3
Any other opinions? I find the current behaviour OK. If a script needs to test whether a table is only or not it should use is_enabled/is_disabled.
(Moving to 0.94.3)
> disable in shell may make confused to user
> -------------------------------------------
>
> Key: HBASE-6668
> URL: https://issues.apache.org/jira/browse/HBASE-6668
> Project: HBase
> Issue Type: Bug
> Components: shell
> Affects Versions: 0.94.1
> Reporter: Zhou wenjian
> Assignee: Zhou wenjian
> Fix For: 0.94.3
>
>
> hbase(main):002:0> disable 'logTable'
> 0 row(s) in 2.0910 seconds
> hbase(main):003:0> disable 'logTable'
> 0 row(s) in 0.0260 seconds
> and we can found table are disabled in log when disable first appears
> but when i disable it again the client just return seemed to be sucessful and I can not find any log described it in the log.
> look into the admin.rb, find below
> #----------------------------------------------------------------------------------------------
> # Disables a table
> def disable(table_name)
> tableExists(table_name)
> return if disabled?(table_name)
> @admin.disableTable(table_name)
> end
> that would confuse us when we found it disabled already but returns nothing
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6668) disable in shell may make confused
to user
Posted by "Zhou wenjian (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13443025#comment-13443025 ]
Zhou wenjian commented on HBASE-6668:
-------------------------------------
[~lhofhansl]
if the table is already disabled, when we disabled it again , it needs to be given some message in shell such as table is disabled already rather than return nothing
> disable in shell may make confused to user
> -------------------------------------------
>
> Key: HBASE-6668
> URL: https://issues.apache.org/jira/browse/HBASE-6668
> Project: HBase
> Issue Type: Bug
> Components: shell
> Affects Versions: 0.94.1
> Reporter: Zhou wenjian
> Assignee: Zhou wenjian
> Fix For: 0.94.2
>
>
> hbase(main):002:0> disable 'logTable'
> 0 row(s) in 2.0910 seconds
> hbase(main):003:0> disable 'logTable'
> 0 row(s) in 0.0260 seconds
> and we can found table are disabled in log when disable first appears
> but when i disable it again the client just return seemed to be sucessful and I can not find any log described it in the log.
> look into the admin.rb, find below
> #----------------------------------------------------------------------------------------------
> # Disables a table
> def disable(table_name)
> tableExists(table_name)
> return if disabled?(table_name)
> @admin.disableTable(table_name)
> end
> that would confuse us when we found it disabled already but returns nothing
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6668) disable in shell may make confused
to user
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13442963#comment-13442963 ]
Lars Hofhansl commented on HBASE-6668:
--------------------------------------
Personally I do not find this unreasonable. If the table is already disabled the disable operation is a no-op.
Do you find this only in 0.94?
> disable in shell may make confused to user
> -------------------------------------------
>
> Key: HBASE-6668
> URL: https://issues.apache.org/jira/browse/HBASE-6668
> Project: HBase
> Issue Type: Bug
> Components: shell
> Affects Versions: 0.94.1
> Reporter: Zhou wenjian
> Assignee: Zhou wenjian
> Fix For: 0.94.2
>
>
> hbase(main):002:0> disable 'logTable'
> 0 row(s) in 2.0910 seconds
> hbase(main):003:0> disable 'logTable'
> 0 row(s) in 0.0260 seconds
> and we can found table are disabled in log when disable first appears
> but when i disable it again the client just return seemed to be sucessful and I can not find any log described it in the log.
> look into the admin.rb, find below
> #----------------------------------------------------------------------------------------------
> # Disables a table
> def disable(table_name)
> tableExists(table_name)
> return if disabled?(table_name)
> @admin.disableTable(table_name)
> end
> that would confuse us when we found it disabled already but returns nothing
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-6668) disable in shell may make confused
to user
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl resolved HBASE-6668.
----------------------------------
Resolution: Won't Fix
No opinions from the other committers, so I am marking as "Won't fix".
Please reopen if you disagree.
> disable in shell may make confused to user
> -------------------------------------------
>
> Key: HBASE-6668
> URL: https://issues.apache.org/jira/browse/HBASE-6668
> Project: HBase
> Issue Type: Bug
> Components: shell
> Affects Versions: 0.94.1
> Reporter: Zhou wenjian
> Assignee: Zhou wenjian
> Fix For: 0.94.3
>
>
> hbase(main):002:0> disable 'logTable'
> 0 row(s) in 2.0910 seconds
> hbase(main):003:0> disable 'logTable'
> 0 row(s) in 0.0260 seconds
> and we can found table are disabled in log when disable first appears
> but when i disable it again the client just return seemed to be sucessful and I can not find any log described it in the log.
> look into the admin.rb, find below
> #----------------------------------------------------------------------------------------------
> # Disables a table
> def disable(table_name)
> tableExists(table_name)
> return if disabled?(table_name)
> @admin.disableTable(table_name)
> end
> that would confuse us when we found it disabled already but returns nothing
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6668) disable in shell may make confused
to user
Posted by "Zhou wenjian (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13442259#comment-13442259 ]
Zhou wenjian commented on HBASE-6668:
-------------------------------------
also appears in enable twice
hbase(main):001:0> enable 'logTable'
0 row(s) in 1.4390 seconds
hbase(main):002:0> enable 'logTable'
0 row(s) in 0.0150 seconds
> disable in shell may make confused to user
> -------------------------------------------
>
> Key: HBASE-6668
> URL: https://issues.apache.org/jira/browse/HBASE-6668
> Project: HBase
> Issue Type: Bug
> Components: shell
> Affects Versions: 0.94.1
> Reporter: Zhou wenjian
> Assignee: Zhou wenjian
> Fix For: 0.94.2
>
>
> hbase(main):002:0> disable 'logTable'
> 0 row(s) in 2.0910 seconds
> hbase(main):003:0> disable 'logTable'
> 0 row(s) in 0.0260 seconds
> and we can found table are disabled in log when disable first appears
> but when i disable it again the client just return seemed to be sucessful and I can not find any log described it in the log.
> look into the admin.rb, find below
> #----------------------------------------------------------------------------------------------
> # Disables a table
> def disable(table_name)
> tableExists(table_name)
> return if disabled?(table_name)
> @admin.disableTable(table_name)
> end
> that would confuse us when we found it disabled already but returns nothing
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6668) disable in shell may make confused
to user
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13454378#comment-13454378 ]
stack commented on HBASE-6668:
------------------------------
I don't think the current behavior that bad.... could be more pleasant but I'd suggest that there are better places to dig where the yields could be much larger if you would like to improve 'user experience'.
> disable in shell may make confused to user
> -------------------------------------------
>
> Key: HBASE-6668
> URL: https://issues.apache.org/jira/browse/HBASE-6668
> Project: HBase
> Issue Type: Bug
> Components: shell
> Affects Versions: 0.94.1
> Reporter: Zhou wenjian
> Assignee: Zhou wenjian
>
> hbase(main):002:0> disable 'logTable'
> 0 row(s) in 2.0910 seconds
> hbase(main):003:0> disable 'logTable'
> 0 row(s) in 0.0260 seconds
> and we can found table are disabled in log when disable first appears
> but when i disable it again the client just return seemed to be sucessful and I can not find any log described it in the log.
> look into the admin.rb, find below
> #----------------------------------------------------------------------------------------------
> # Disables a table
> def disable(table_name)
> tableExists(table_name)
> return if disabled?(table_name)
> @admin.disableTable(table_name)
> end
> that would confuse us when we found it disabled already but returns nothing
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6668) disable in shell may make confused
to user
Posted by "Zhou wenjian (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13443027#comment-13443027 ]
Zhou wenjian commented on HBASE-6668:
-------------------------------------
@Lars
fonud in 94, did not check other versions
> disable in shell may make confused to user
> -------------------------------------------
>
> Key: HBASE-6668
> URL: https://issues.apache.org/jira/browse/HBASE-6668
> Project: HBase
> Issue Type: Bug
> Components: shell
> Affects Versions: 0.94.1
> Reporter: Zhou wenjian
> Assignee: Zhou wenjian
> Fix For: 0.94.2
>
>
> hbase(main):002:0> disable 'logTable'
> 0 row(s) in 2.0910 seconds
> hbase(main):003:0> disable 'logTable'
> 0 row(s) in 0.0260 seconds
> and we can found table are disabled in log when disable first appears
> but when i disable it again the client just return seemed to be sucessful and I can not find any log described it in the log.
> look into the admin.rb, find below
> #----------------------------------------------------------------------------------------------
> # Disables a table
> def disable(table_name)
> tableExists(table_name)
> return if disabled?(table_name)
> @admin.disableTable(table_name)
> end
> that would confuse us when we found it disabled already but returns nothing
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira