You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Guillaume Nodet (JIRA)" <ji...@apache.org> on 2012/07/16 17:00:47 UTC
[jira] [Commented] (FELIX-3597) Hard to debug fileinstall because
shaded classes lack source in -sources.jar
[ https://issues.apache.org/jira/browse/FELIX-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415202#comment-13415202 ]
Guillaume Nodet commented on FELIX-3597:
----------------------------------------
We'd need to build a shaded source jars, the same way we do for servicemix plugins.
See https://github.com/apache/servicemix4-bundles/blob/trunk/asm-3.3.1/pom.xml
Do you think you could provide a patch for that ?
> Hard to debug fileinstall because shaded classes lack source in -sources.jar
> ----------------------------------------------------------------------------
>
> Key: FELIX-3597
> URL: https://issues.apache.org/jira/browse/FELIX-3597
> Project: Felix
> Issue Type: Wish
> Components: File Install
> Affects Versions: fileinstall-3.2.2
> Environment: Apache Karaf 2.2.7, IDEA 10.5
> Reporter: Chris Dolan
> Priority: Minor
>
> fileinstall uses bnd arguments to slurp in classes from other jars:
> {code}
> <Embed-Dependency>
> org.apache.felix.configadmin;inline="org/apache/felix/cm/file/ConfigurationHandler.*",
> org.apache.felix.utils;inline="org/apache/felix/utils/collections/DictionaryAsMap*.*"
> </Embed-Dependency>
> {code}
> However, this does not pull the sources for those classes into the fileinstall-sources.jar file. This makes it difficult to debug into the classes (specifically, I got stuck trying to debug a parsing problem in ConfigurationHandler)
> I'm guessing this isn't the fault of fileinstall at all but instead is the fault of the maven plugin that does the shading...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Commented] (FELIX-3597) Hard to debug fileinstall because shaded classes lack source in -sources.jar
Posted by David Jencks <da...@yahoo.com>.
A much better solution would be to fix up the maven bundle plugin (and probably bnd) to construct the source jar matching the assembled bundle. I suspect bnd already does this if you mix the source and class files in the same jar so if might not be too much surgery on bnd to get this to work.
Since no packages were harmed/changed I don't think terming this shading is appropriate.
david jencks
On Jul 16, 2012, at 11:00 AM, Guillaume Nodet (JIRA) wrote:
>
> [ https://issues.apache.org/jira/browse/FELIX-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415202#comment-13415202 ]
>
> Guillaume Nodet commented on FELIX-3597:
> ----------------------------------------
>
> We'd need to build a shaded source jars, the same way we do for servicemix plugins.
> See https://github.com/apache/servicemix4-bundles/blob/trunk/asm-3.3.1/pom.xml
>
> Do you think you could provide a patch for that ?
>
>> Hard to debug fileinstall because shaded classes lack source in -sources.jar
>> ----------------------------------------------------------------------------
>>
>> Key: FELIX-3597
>> URL: https://issues.apache.org/jira/browse/FELIX-3597
>> Project: Felix
>> Issue Type: Wish
>> Components: File Install
>> Affects Versions: fileinstall-3.2.2
>> Environment: Apache Karaf 2.2.7, IDEA 10.5
>> Reporter: Chris Dolan
>> Priority: Minor
>>
>> fileinstall uses bnd arguments to slurp in classes from other jars:
>> {code}
>> <Embed-Dependency>
>> org.apache.felix.configadmin;inline="org/apache/felix/cm/file/ConfigurationHandler.*",
>> org.apache.felix.utils;inline="org/apache/felix/utils/collections/DictionaryAsMap*.*"
>> </Embed-Dependency>
>> {code}
>> However, this does not pull the sources for those classes into the fileinstall-sources.jar file. This makes it difficult to debug into the classes (specifically, I got stuck trying to debug a parsing problem in ConfigurationHandler)
>> I'm guessing this isn't the fault of fileinstall at all but instead is the fault of the maven plugin that does the shading...
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>