[GitHub] JaroslavTulach opened a new pull request #420: Make sure compilation of a module also compiles its tests

[GitBox <gi...@apache.org>]

JaroslavTulach opened a new pull request #420: Make sure compilation of a module also compiles its tests
URL: https://github.com/apache/incubator-netbeans/pull/420
 
 
   I'd like to contribute to the quality of NetBeans codebase. One of the common problems of our own harness (in contrary to Maven) is that by default compilation compiles only code, but not tests. As such, it often happens that developers forget to update the tests when refactoring their code. Yes, such mistake would ultimately be caught by Travis job, but checking for it during regular build would catch it sooner and bring the development experience closer to what people using Maven or Gradle expect.
   
   I've done some testing and following commands seem to build OK with my change:
   ```bash
   incubator-netbeans$ for i in *core*; do echo $i; ant -f $i/build.xml netbeans; done
   incubator-netbeans$ for i in java*; do echo $i; ant -f $i/build.xml netbeans; done
   ```
   thus my assumption is that the change is relatively safe for NetBeans own development.
   
   On the other hand, I changed `common.xml` (I know it is better not to touch that file), and that may influence people using the harness to build their own applications. As such I am requesting review from Jesse.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists