[jira] [Commented] (MESOS-9629) Pylint reports cyclic dependencies in cli_new

["Benjamin Bannier (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-9629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16782675#comment-16782675 ] 

Benjamin Bannier commented on MESOS-9629:
-----------------------------------------

Reviews:

https://reviews.apache.org/r/70090/
https://reviews.apache.org/r/70092/

> Pylint reports cyclic dependencies in cli_new
> ---------------------------------------------
>
>                 Key: MESOS-9629
>                 URL: https://issues.apache.org/jira/browse/MESOS-9629
>             Project: Mesos
>          Issue Type: Bug
>          Components: cli
>            Reporter: Benjamin Bannier
>            Assignee: Benjamin Bannier
>            Priority: Minor
>
> When running {{support/mesos-style.py}} over files in {{src/python/cli_new}} cyclic dependencies in {{cli}} are reported.
> {noformat}
> $ ./support/mesos-style.py `find src/python/cli_new -type f |grep -v \.tox -v |grep -v \.virtualenv`
> The "pip-requirements.txt" file has changed.
> Rebuilding virtualenv...
>  * Install prebuilt node (11.10.1) ..... done.
>  * Appending data to /Users/bbannier/src/mesos/support/.virtualenv/bin/activate
>  * Appending data to /Users/bbannier/src/mesos/support/.virtualenv/bin/activate.fish
> Checking 26 Python files
> ************* Module cli.plugins.task.main
> lib/cli/plugins/task/main.py:1:0: R0401: Cyclic import (cli -> cli.plugins -> cli.plugins.base) (cyclic-import)
> lib/cli/plugins/task/main.py:1:0: R0401: Cyclic import (cli -> cli.config) (cyclic-import)
> lib/cli/plugins/task/main.py:1:0: R0401: Cyclic import (cli.tests -> cli.tests.task) (cyclic-import)
> lib/cli/plugins/task/main.py:1:0: R0401: Cyclic import (cli.tests -> cli.tests.agent) (cyclic-import)
> lib/cli/plugins/task/main.py:1:0: R0401: Cyclic import (cli.tests -> cli.tests.tests) (cyclic-import)
> {noformat}
> The exact module {{pylint}} diagnoses this at was not determistic for me.
> I was not able to trigger this failure when passing only a single file.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)