You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by xubo245 <gi...@git.apache.org> on 2018/01/11 02:05:23 UTC
[GitHub] spark pull request #20227: [SPARK-23035] Fix warning: TEMPORARY TABLE ... US...
GitHub user xubo245 opened a pull request:
https://github.com/apache/spark/pull/20227
[SPARK-23035] Fix warning: TEMPORARY TABLE ... USING ... is deprecated and use TempViewAlreadyExistsException when create temp view
Fix warning: TEMPORARY TABLE ... USING ... is deprecated and use TempViewAlreadyExistsException when create temp view
There are warning when run test: test("rename temporary view - destination table with database name")
Another problem, it throw TempTableAlreadyExistsException and output "Temporary table '$table' already exists" when we create temp view by using org.apache.spark.sql.catalyst.catalog.GlobalTempViewManager#create, it's improper.
## What changes were proposed in this pull request?
Fix some warning by changing "TEMPORARY TABLE ... USING ... " to "TEMPORARY VIEW ... USING
... "
Fix improper information about TempTableAlreadyExistsException when create temp view
## How was this patch tested?
use old test cases, such as " test("create temporary view using") "
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xubo245/spark fixDeprecated
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20227.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20227
----
commit b97834a58fb29999a0a98eb2645bd9e77e97209b
Author: xubo245 <60...@...>
Date: 2018-01-11T01:58:48Z
[SPARK-23035] Fix warning: TEMPORARY TABLE ... USING ... is deprecated and use TempViewAlreadyExistsException when create temp view
Fix warning: TEMPORARY TABLE ... USING ... is deprecated and use TempViewAlreadyExistsException when create temp view
There are warning when run test: test("rename temporary view - destination table with database name")
Another problem, it throw TempTableAlreadyExistsException and output "Temporary table '$table' already exists" when we create temp view by using org.apache.spark.sql.catalyst.catalog.GlobalTempViewManager#create, it's improper.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20227: [SPARK-23035][SQL] Fix warning: TEMPORARY TABLE ....
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20227#discussion_r161022261
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/AlreadyExistException.scala ---
@@ -33,6 +33,9 @@ class TableAlreadyExistsException(db: String, table: String)
class TempTableAlreadyExistsException(table: String)
extends AnalysisException(s"Temporary table '$table' already exists")
--- End diff --
+1.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20227: [SPARK-23035][SQL] Fix warning: TEMPORARY TABLE ... USIN...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20227
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86104/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20227: [SPARK-23035][SQL] Fix warning: TEMPORARY TABLE ... USIN...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20227
**[Test build #86113 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86113/testReport)** for PR 20227 at commit [`a062dd3`](https://github.com/apache/spark/commit/a062dd39d9976e1ef3318850e180a779abe984ba).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20227: [SPARK-23035][SQL] Fix improper information of TempTable...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/spark/pull/20227
@dongjoon-hyun ok ,done. Jira webpage shows "Maintenance in progress"
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20227: [SPARK-23035][SQL] Fix warning: TEMPORARY TABLE ... USIN...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20227
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20227: [SPARK-23035][SQL] Fix warning: TEMPORARY TABLE ... USIN...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20227
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20227: [SPARK-23035][SQL] Fix warning: TEMPORARY TABLE ....
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20227#discussion_r161003157
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/AlreadyExistException.scala ---
@@ -33,6 +33,9 @@ class TableAlreadyExistsException(db: String, table: String)
class TempTableAlreadyExistsException(table: String)
extends AnalysisException(s"Temporary table '$table' already exists")
--- End diff --
You just need to change `Temporary table` to `Temporary view`.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20227: [SPARK-23035][SQL] Fix warning: TEMPORARY TABLE ....
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20227#discussion_r161367362
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala ---
@@ -814,7 +814,7 @@ abstract class DDLSuite extends QueryTest with SQLTestUtils {
withTempView("tab1") {
sql(
"""
- |CREATE TEMPORARY TABLE tab1
--- End diff --
Ok, done. I keep the old test cases for test coverage, and add new test cases for temp view
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20227: [SPARK-23035] Fix warning: TEMPORARY TABLE ... US...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20227#discussion_r160867069
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/AlreadyExistException.scala ---
@@ -33,6 +33,9 @@ class TableAlreadyExistsException(db: String, table: String)
class TempTableAlreadyExistsException(table: String)
extends AnalysisException(s"Temporary table '$table' already exists")
+class TempViewAlreadyExistsException(table: String)
+ extends AnalysisException(s"Temporary view '$table' already exists")
--- End diff --
+1 for adding this.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20227: [SPARK-23035][SQL] Fix improper information of Te...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20227#discussion_r161981394
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/AlreadyExistException.scala ---
@@ -31,7 +31,7 @@ class TableAlreadyExistsException(db: String, table: String)
extends AnalysisException(s"Table or view '$table' already exists in database '$db'")
class TempTableAlreadyExistsException(table: String)
--- End diff --
I think we should rename it. But @gatorsmile said "We do not want to introduce a new exception type. In contrast, we planned to remove all these exception sub-types because PySpark might output a confusing error message.". So I revert it.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20227: [SPARK-23035][SQL] Fix warning: TEMPORARY TABLE ... USIN...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20227
**[Test build #86123 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86123/testReport)** for PR 20227 at commit [`a062dd3`](https://github.com/apache/spark/commit/a062dd39d9976e1ef3318850e180a779abe984ba).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20227: [SPARK-23035][SQL] Fix warning: TEMPORARY TABLE ... USIN...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20227
**[Test build #86104 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86104/testReport)** for PR 20227 at commit [`462ec73`](https://github.com/apache/spark/commit/462ec737bbc5a70b005d2b4cdc427b06535b2cc8).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20227: [SPARK-23035][SQL] Fix warning: TEMPORARY TABLE ....
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20227#discussion_r161366875
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/AlreadyExistException.scala ---
@@ -33,6 +33,9 @@ class TableAlreadyExistsException(db: String, table: String)
class TempTableAlreadyExistsException(table: String)
extends AnalysisException(s"Temporary table '$table' already exists")
--- End diff --
How about the class name? TempTableAlreadyExistsException
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20227: [SPARK-23035][SQL] Fix warning: TEMPORARY TABLE ... USIN...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20227
**[Test build #86110 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86110/testReport)** for PR 20227 at commit [`c0b0f23`](https://github.com/apache/spark/commit/c0b0f23ac71ec7fddebf30048598dedd523e27c6).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20227: [SPARK-23035][SQL] Fix improper information of Te...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20227#discussion_r161781792
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/AlreadyExistException.scala ---
@@ -31,7 +31,7 @@ class TableAlreadyExistsException(db: String, table: String)
extends AnalysisException(s"Table or view '$table' already exists in database '$db'")
class TempTableAlreadyExistsException(table: String)
--- End diff --
shall we rename it to `TempViewAlreadyExistsException`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20227: [SPARK-23035] Fix warning: TEMPORARY TABLE ... US...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20227#discussion_r160867160
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala ---
@@ -814,7 +814,7 @@ abstract class DDLSuite extends QueryTest with SQLTestUtils {
withTempView("tab1") {
sql(
"""
- |CREATE TEMPORARY TABLE tab1
--- End diff --
For this one, I think we should keep the test coverage because we still support this legacy syntax.
Could you revert this kind of changes?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20227: [SPARK-23035] Fix warning: TEMPORARY TABLE ... USING ......
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20227
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20227: [SPARK-23035][SQL] Fix warning: TEMPORARY TABLE ....
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20227#discussion_r161386989
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala ---
@@ -883,6 +908,41 @@ abstract class DDLSuite extends QueryTest with SQLTestUtils {
}
}
+ test("rename temporary view - destination table already exists, with sql: CREATE TEMPORARY view") {
--- End diff --
ok， done
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20227: [SPARK-23035][SQL] Fix warning: TEMPORARY TABLE ... USIN...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20227
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20227: [SPARK-23035][SQL] Fix improper information of Te...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20227
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20227: [SPARK-23035][SQL] Fix warning: TEMPORARY TABLE ... USIN...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20227
**[Test build #86113 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86113/testReport)** for PR 20227 at commit [`a062dd3`](https://github.com/apache/spark/commit/a062dd39d9976e1ef3318850e180a779abe984ba).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20227: [SPARK-23035][SQL] Fix warning: TEMPORARY TABLE ....
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20227#discussion_r161022213
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/AlreadyExistException.scala ---
@@ -33,6 +33,9 @@ class TableAlreadyExistsException(db: String, table: String)
class TempTableAlreadyExistsException(table: String)
extends AnalysisException(s"Temporary table '$table' already exists")
+class TempViewAlreadyExistsException(table: String)
+ extends AnalysisException(s"Temporary view '$table' already exists")
--- End diff --
Oh, I see. Thank you for informing me the direction!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20227: [SPARK-23035][SQL] Fix warning: TEMPORARY TABLE ... USIN...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20227
**[Test build #86123 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86123/testReport)** for PR 20227 at commit [`a062dd3`](https://github.com/apache/spark/commit/a062dd39d9976e1ef3318850e180a779abe984ba).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20227: [SPARK-23035][SQL] Fix warning: TEMPORARY TABLE ....
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20227#discussion_r161378421
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala ---
@@ -883,6 +908,41 @@ abstract class DDLSuite extends QueryTest with SQLTestUtils {
}
}
+ test("rename temporary view - destination table already exists, with sql: CREATE TEMPORARY view") {
--- End diff --
indent.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20227: [SPARK-23035][SQL] Fix improper information of TempTable...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20227
Thanks! Merged to master/2.3
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20227: [SPARK-23035][SQL] Fix warning: TEMPORARY TABLE ... USIN...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20227
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20227: [SPARK-23035][SQL] Fix warning: TEMPORARY TABLE ... USIN...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20227
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86110/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20227: [SPARK-23035][SQL] Fix warning: TEMPORARY TABLE ....
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20227#discussion_r161367322
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/AlreadyExistException.scala ---
@@ -33,6 +33,9 @@ class TableAlreadyExistsException(db: String, table: String)
class TempTableAlreadyExistsException(table: String)
extends AnalysisException(s"Temporary table '$table' already exists")
+class TempViewAlreadyExistsException(table: String)
+ extends AnalysisException(s"Temporary view '$table' already exists")
--- End diff --
ok, I will remove new exception
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20227: [SPARK-23035][SQL] Fix warning: TEMPORARY TABLE ... USIN...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/spark/pull/20227
Retest this please.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20227: [SPARK-23035][SQL] Fix warning: TEMPORARY TABLE ... USIN...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20227
retest this please
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20227: [SPARK-23035][SQL] Fix warning: TEMPORARY TABLE ... USIN...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20227
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86113/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20227: [SPARK-23035][SQL] Fix warning: TEMPORARY TABLE ... USIN...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20227
**[Test build #86110 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86110/testReport)** for PR 20227 at commit [`c0b0f23`](https://github.com/apache/spark/commit/c0b0f23ac71ec7fddebf30048598dedd523e27c6).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20227: [SPARK-23035][SQL] Fix warning: TEMPORARY TABLE ... USIN...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20227
ok to test
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20227: [SPARK-23035][SQL] Fix warning: TEMPORARY TABLE ....
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20227#discussion_r161003528
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/AlreadyExistException.scala ---
@@ -33,6 +33,9 @@ class TableAlreadyExistsException(db: String, table: String)
class TempTableAlreadyExistsException(table: String)
extends AnalysisException(s"Temporary table '$table' already exists")
+class TempViewAlreadyExistsException(table: String)
+ extends AnalysisException(s"Temporary view '$table' already exists")
--- End diff --
We do not want to introduce a new exception type. In contrast, we planned to remove all these exception types because PySpark might output a confusing error message.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20227: [SPARK-23035][SQL] Fix warning: TEMPORARY TABLE ... USIN...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20227
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86123/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20227: [SPARK-23035][SQL] Fix warning: TEMPORARY TABLE ... USIN...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20227
**[Test build #86104 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86104/testReport)** for PR 20227 at commit [`462ec73`](https://github.com/apache/spark/commit/462ec737bbc5a70b005d2b4cdc427b06535b2cc8).
* This patch **fails Scala style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org