You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/08 17:21:54 UTC
[GitHub] [apisix-dashboard] liuxiran opened a new pull request #1723: fix: remote proxy-rewrite plugin out of create plugin template config view
liuxiran opened a new pull request #1723:
URL: https://github.com/apache/apisix-dashboard/pull/1723
Please answer these questions before submitting a pull request, **or your PR will get closed**.
**Why submit this pull request?**
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
**What changes will this PR take into?**
Remove `proxy-rewrite` out of create plugin template config step2 , just keep the same as the create route step3 does.
**Related issues**
fix/resolve #1719
**Checklist:**
- [x] Did you explain what problem does this PR solve? Or what new features have been added?
- [ ] Have you added corresponding test cases?
- [ ] Have you modified the corresponding document?
- [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1723: fix: remote proxy-rewrite plugin out of create plugin template config view
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1723:
URL: https://github.com/apache/apisix-dashboard/pull/1723#discussion_r610292463
##########
File path: web/src/pages/PluginTemplate/Create.tsx
##########
@@ -108,7 +108,12 @@ const Page: React.FC = (props) => {
{step === 1 && <Step1 form={form1} />}
{step === 2 && (
- <PluginPage initialData={plugins} onChange={setPlugins} schemaType="route" />
+ <PluginPage
Review comment:
yep
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] jbampton commented on a change in pull request #1723: fix: remote proxy-rewrite plugin out of create plugin template config view
Posted by GitBox <gi...@apache.org>.
jbampton commented on a change in pull request #1723:
URL: https://github.com/apache/apisix-dashboard/pull/1723#discussion_r610278786
##########
File path: web/src/pages/PluginTemplate/Create.tsx
##########
@@ -108,7 +108,12 @@ const Page: React.FC = (props) => {
{step === 1 && <Step1 form={form1} />}
{step === 2 && (
- <PluginPage initialData={plugins} onChange={setPlugins} schemaType="route" />
+ <PluginPage
Review comment:
I have never done `.tsx` before, but when I try to do HTML attributes I like to order them alphabetically.
Suggested change:
```
<PluginPage
initialData={plugins}
onChange={setPlugins}
referPage="route"
schemaType="route"
/>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1723: fix: remote proxy-rewrite plugin out of create plugin template config view
Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #1723:
URL: https://github.com/apache/apisix-dashboard/pull/1723#discussion_r610303787
##########
File path: web/src/pages/PluginTemplate/Create.tsx
##########
@@ -108,7 +108,12 @@ const Page: React.FC = (props) => {
{step === 1 && <Step1 form={form1} />}
{step === 2 && (
- <PluginPage initialData={plugins} onChange={setPlugins} schemaType="route" />
+ <PluginPage
Review comment:
thanks for your useful advice, I have updated the code, PTAL when you are free. @justinmclean
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] imjoey merged pull request #1723: fix: remove proxy-rewrite plugin out of create plugin template config view
Posted by GitBox <gi...@apache.org>.
imjoey merged pull request #1723:
URL: https://github.com/apache/apisix-dashboard/pull/1723
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org