[GitHub] [lucene-solr] dweiss commented on a change in pull request #2253: LUCENE-9702: Hunspell: support alternate casing for short language codes

[GitBox <gi...@apache.org>]

dweiss commented on a change in pull request #2253:
URL: https://github.com/apache/lucene-solr/pull/2253#discussion_r566629532



##########
File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Dictionary.java
##########
@@ -370,7 +370,7 @@ private void readAffixFile(InputStream affixStream, CharsetDecoder decoder)
         fullStrip = true;
       } else if ("LANG".equals(firstWord)) {
         language = singleArgument(reader, line);
-        alternateCasing = "tr_TR".equals(language) || "az_AZ".equals(language);

Review comment:
       Hmm... I didn't check but can we use Locale to parse it properly to extract the language from country variant? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org