You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by fonini <gi...@git.apache.org> on 2014/08/18 22:07:42 UTC

[GitHub] cordova-plugin-dialogs pull request: Fix for AlertDialog.Builder o...

GitHub user fonini opened a pull request:

    https://github.com/apache/cordova-plugin-dialogs/pull/27

    Fix for AlertDialog.Builder on API lower than 11

    When the API is lower than 11, Android throws an NoSuchMethodError because of the second parameter.
    This pull request fixes it.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fonini/cordova-plugin-dialogs master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-dialogs/pull/27.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #27
    
----
commit ae8df8edcf018c56e253d6c9bd43d7f1b4ec6347
Author: Jonnas Fonini <jo...@gmail.com>
Date:   2014-08-18T20:05:57Z

    Fix for AlertDialog.Builder on API lower than 11

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-dialogs pull request: Fix for AlertDialog.Builder o...

Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:

    https://github.com/apache/cordova-plugin-dialogs/pull/27#issuecomment-157957992
  
    Thanks fonini! This was addressed in #31 
    Closing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org

[GitHub] cordova-plugin-dialogs pull request: Fix for AlertDialog.Builder o...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-plugin-dialogs/pull/27


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org