[GitHub] ocafebabe commented on a change in pull request #465: [NETBEANS-519] Bump Eclipse JGit dependency to latest version

[GitBox <gi...@apache.org>]

ocafebabe commented on a change in pull request #465: [NETBEANS-519] Bump Eclipse JGit dependency to latest version
URL: https://github.com/apache/incubator-netbeans/pull/465#discussion_r176951701
 
 

 ##########
 File path: nbbuild/cluster.properties
 ##########
 @@ -420,6 +420,7 @@ nb.cluster.ide=\
         o.apache.commons.io,\
         o.apache.commons.lang,\
         o.apache.commons.logging,\
+        o.apache.servicemix.bundles.jsch,\
 
 Review comment:
   Yes we do but this version isn't OSGi compliant and there has been a change in the manifest file of JGit starting from version 4.5 that now requires this dependency to be part of an OSGi bundle: 
   
   https://github.com/eclipse/jgit/commit/e2cb2f8afdcfc3505f0d7ab0e084415c9358139a#diff-66e59ab180153a142ed3da762d562591
   
   And this Apache repackaged version has been made specifically for this purpose so I thought it was a good fit. 
   
   I guess a more proper way of handling these external OSGi dependencies would be to use the ones built directly by the Eclipse team! And I've tried to do that at first but they aren't available on Maven Central (see my post on the orbit-dev mailing list: https://dev.eclipse.org/mhonarc/lists/orbit-dev/msg04952.html)! Currently they are only available through Eclipse Orbit (P2) repository: http://download.eclipse.org/tools/orbit/downloads/drops/R20180206163158/
   
   Maybe we could use Tycho to fetch these dependencies from the Orbit repository but I'm not familiar enough with Ant and the NetBeans build system to implement that...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists