You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2020/04/08 05:02:41 UTC
[GitHub] [carbondata] kunal642 commented on a change in pull request #3686:
[CARBONDATA-3759]Refactor segmentRefreshInfo and fix cache issue in
multiple application scenario
kunal642 commented on a change in pull request #3686: [CARBONDATA-3759]Refactor segmentRefreshInfo and fix cache issue in multiple application scenario
URL: https://github.com/apache/carbondata/pull/3686#discussion_r405259513
##########
File path: core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentUpdateStatusManager.java
##########
@@ -783,26 +783,28 @@ private static void closeStreams(Closeable... streams) {
/**
* Returns the invalid timestamp range of a segment.
- * @param segmentId
- * @return
*/
- public UpdateVO getInvalidTimestampRange(String segmentId) {
+ public static UpdateVO getInvalidTimestampRange(LoadMetadataDetails loadMetadataDetails) {
UpdateVO range = new UpdateVO();
- for (LoadMetadataDetails segment : segmentDetails) {
- if (segment.getLoadName().equalsIgnoreCase(segmentId)) {
- range.setSegmentId(segmentId);
- range.setFactTimestamp(segment.getLoadStartTime());
- if (!segment.getUpdateDeltaStartTimestamp().isEmpty() && !segment
- .getUpdateDeltaEndTimestamp().isEmpty()) {
- range.setUpdateDeltaStartTimestamp(
- CarbonUpdateUtil.getTimeStampAsLong(segment.getUpdateDeltaStartTimestamp()));
- range.setLatestUpdateTimestamp(
- CarbonUpdateUtil.getTimeStampAsLong(segment.getUpdateDeltaEndTimestamp()));
- }
- return range;
+ if (getInvalidTimeStampRange(range, loadMetadataDetails)) return range;
+ return range;
Review comment:
if check can be removed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services