[GitHub] WillemJiang commented on a change in pull request #681: [SCB-526]fetch once from dynamic config source when boot up

[GitBox <gi...@apache.org>]

WillemJiang commented on a change in pull request #681: [SCB-526]fetch once from dynamic config source when boot up
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/681#discussion_r185385337
 
 

 ##########
 File path: dynamic-config/config-cc/src/main/java/org/apache/servicecomb/config/client/ConfigCenterClient.java
 ##########
 @@ -155,8 +161,21 @@ private void refreshMembers(MemberDiscovery memberDiscovery) {
           request.headers().add("X-Auth-Token", ConfigCenterConfig.INSTANCE.getToken());
         }
         authHeaderProviders.forEach(provider -> request.headers().addAll(provider.getSignAuthHeaders(signReq)));
+        request.exceptionHandler(e -> {
+          LOGGER.error("Fetch member from {} failed. Error message is [{}].", configCenter, e.getMessage());
+          latch.countDown();
+        });
         request.end();
       });
+      if (wait) {
+        LOGGER.info("Refreshing config center members...");
 
 Review comment:
   It just wait for latch, we need to write the log in the fetching method of config center client.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services