[GitHub] sijie commented on a change in pull request #1941: (WIP) Exclude defaultrack bookies when enforceMinNumRacksPerWriteQuorum is enabled

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #1941: (WIP) Exclude defaultrack bookies when enforceMinNumRacksPerWriteQuorum is enabled
URL: https://github.com/apache/bookkeeper/pull/1941#discussion_r255279807
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java
 ##########
 @@ -240,7 +237,16 @@ public void reloadCachedMappings() {
         help = "The distribution of number of bookies reordered on each read request"
     )
     protected OpStatsLogger readReorderedCounter = null;
+    @StatsDoc(
+            name = FAILED_TO_RESOLVE_NETWORK_LOCATION_COUNTER,
+            help = "Counter for number of times DNSResolverDecorator failed to resolve Network Location"
+    )
     protected Counter failedToResolveNetworkLocationCounter = null;
+    @StatsDoc(
+            name = NUM_BOOKIES_IN_DEFAULT_FAULTZONE,
+            help = "Gauge for the number of Bookies in default Fault Zone"
+    )
+    protected Gauge<Integer> numBookiesInDefaultFaultZone;
 
 Review comment:
   we rarely use "fault zone" in bookkeeper's concept. I would prefer using a consistent name in the same file, e.g. calling it default rack.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services