You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by Netroby <hu...@gmail.com> on 2017/03/31 10:12:21 UTC
Disagree with "https://rocketmq.apache.org/the-correct-posture-of-submitting-pull-request/"
fork origin repository
I see the new blog talk about how to submitting pull request.
https://rocketmq.apache.org/the-correct-posture-of-submitting-pull-request/
As the blog describe, people who need send pull request, must fork a
repository belong to
https://github.com/dongeforever
He currently working for alibaba.
If he leave alibaba. and deleted the repository. so what will happen?
why not make apache/incubator-rocketmq the only one main repository.
Appreciate your time.
----------------------------
Netroby
Re: Disagree with "https://rocketmq.apache.org/the-correct-posture-of-submitting-pull-request/"fork origin repository
Posted by dongeforever <10...@qq.com>.
Hi Netroby:
Maybe I describe something in a wrong way.
As blog said "fork the original repo, and clone it":
Forking the original repo is not a command, but an operation on github.com, so it was left out.
And the https://github.com/dongeforever/incubator-rocketmq.git is the forked repo, just an example here.
After forking and cloning, still need to add origin repo, just as the blog shows.
Sorry to make you misunderstand this, and blog will be polished soon.
Regards
dongeforever
------------------ Original ------------------
From: "Netroby";<hu...@gmail.com>;
Date: Fri, Mar 31, 2017 06:12 PM
To: "dev-rocketmq"<de...@rocketmq.incubator.apache.org>;
Subject: Disagree with "https://rocketmq.apache.org/the-correct-posture-of-submitting-pull-request/"fork origin repository
I see the new blog talk about how to submitting pull request.
https://rocketmq.apache.org/the-correct-posture-of-submitting-pull-request/
As the blog describe, people who need send pull request, must fork a
repository belong to
https://github.com/dongeforever
He currently working for alibaba.
If he leave alibaba. and deleted the repository. so what will happen?
why not make apache/incubator-rocketmq the only one main repository.
Appreciate your time.
----------------------------
Netroby
Re: Disagree with
"https://rocketmq.apache.org/the-correct-posture-of-submitting-pull-request/"
fork origin repository
Posted by Xinyu Zhou <zh...@xinyu.im>.
Hi,
There is no doubt that apache/incubator-rocketmq is the main and unique
repo.
Regards,
yukon
On Fri, Mar 31, 2017 at 6:12pm, Netroby < hufeng1987@gmail.com
[hufeng1987@gmail.com] > wrote:
I see the new blog talk about how to submitting pull request.
https://rocketmq.apache.org/the-correct-posture-of-submitting-pull-request/
As the blog describe, people who need send pull request, must fork a
repository belong to
https://github.com/dongeforever
He currently working for alibaba.
If he leave alibaba. and deleted the repository. so what will happen?
why not make apache/incubator-rocketmq the only one main repository.
Appreciate your time.
----------------------------
Netroby
Re: Disagree with "https://rocketmq.apache.org/the-correct-posture-of-submitting-pull-request/"
fork origin repository
Posted by Xin Wang <da...@gmail.com>.
I guess this is a bug.
>
> git clone https://github.com/dongeforever/incubator-rocketmq.git
should be fixed to https://github.com/apache/incubator-rocketmq.git
And "dongeforever" in the page[1] is just used as a ordinary user. Since
@dongeforever is the Rocket committer this may be misleading for users.
"foo" may be a good name.
[1]
https://rocketmq.apache.org/the-correct-posture-of-submitting-pull-request/
- Xin Wang
2017-03-31 18:12 GMT+08:00 Netroby <hu...@gmail.com>:
> I see the new blog talk about how to submitting pull request.
>
> https://rocketmq.apache.org/the-correct-posture-of-
> submitting-pull-request/
>
> As the blog describe, people who need send pull request, must fork a
> repository belong to
>
> https://github.com/dongeforever
>
> He currently working for alibaba.
> If he leave alibaba. and deleted the repository. so what will happen?
>
> why not make apache/incubator-rocketmq the only one main repository.
>
>
>
> Appreciate your time.
> ----------------------------
> Netroby
>
Re: Disagreewith"https://rocketmq.apache.org/the-correct-posture-of-submitting-pull-request/"forkorigin repository
Posted by dongeforever <10...@qq.com>.
Hi,
Thanks for your preciseness. It impressed on me a lot.
And some polishing is done[1].
[1] https://rocketmq.apache.org/the-correct-posture-of-submitting-pull-request/
Regards
dongeforever
------------------ Original ------------------
From: "Justin Mclean";<ju...@classsoftware.com>;
Date: Sun, Apr 2, 2017 10:55 AM
To: "dev"<de...@rocketmq.incubator.apache.org>;
Subject: Re: Disagreewith"https://rocketmq.apache.org/the-correct-posture-of-submitting-pull-request/"forkorigin repository
Hi,
> [1] https://rocketmq.apache.org/the-correct-posture-of-submitting-pull-request/
You may want to make it clear that GitHub is a read only mirror of the original git repo at Apache not the original repo.
Thanks,
Justin
Re: Disagree
with"https://rocketmq.apache.org/the-correct-posture-of-submitting-pull-request/"fork
origin repository
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> [1] https://rocketmq.apache.org/the-correct-posture-of-submitting-pull-request/
You may want to make it clear that GitHub is a read only mirror of the original git repo at Apache not the original repo.
Thanks,
Justin
Re: Disagree with"https://rocketmq.apache.org/the-correct-posture-of-submitting-pull-request/"fork origin repository
Posted by dongeforever <10...@qq.com>.
Hi Justin:
No doubt that
> The correct URL is:
> git://git.apache.org/incubator-rocketmq.git <git://git.apache.org/incubator-rocketmq.git>
> There is a read only mirror on GitHub at:
> https://github.com/apache/incubator-rocketmq
"https://github.com/dongeforever" is just the forked repo, and has been changed as "https://github.com/foo".
And the blog has been polished with more clear words[1]
[1] https://rocketmq.apache.org/the-correct-posture-of-submitting-pull-request/
Regards
dongeforever
------------------ Original ------------------
From: "Justin Mclean";<ju...@classsoftware.com>;
Date: Sun, Apr 2, 2017 10:03 AM
To: "dev"<de...@rocketmq.incubator.apache.org>;
Subject: Re: Disagree with"https://rocketmq.apache.org/the-correct-posture-of-submitting-pull-request/"fork origin repository
Hi,
> https://rocketmq.apache.org/the-correct-posture-of-submitting-pull-request/
>
> As the blog describe, people who need send pull request, must fork a
> repository belong to
>
> https://github.com/dongeforever
That is not the correct URL.
The correct URL is:
git://git.apache.org/incubator-rocketmq.git <git://git.apache.org/incubator-rocketmq.git>
There is a read only mirror on GitHub at:
https://github.com/apache/incubator-rocketmq
Thanks,
Justin
Re: Disagree with
"https://rocketmq.apache.org/the-correct-posture-of-submitting-pull-request/"
fork origin repository
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> https://rocketmq.apache.org/the-correct-posture-of-submitting-pull-request/
>
> As the blog describe, people who need send pull request, must fork a
> repository belong to
>
> https://github.com/dongeforever
That is not the correct URL.
The correct URL is:
git://git.apache.org/incubator-rocketmq.git <git://git.apache.org/incubator-rocketmq.git>
There is a read only mirror on GitHub at:
https://github.com/apache/incubator-rocketmq
Thanks,
Justin