You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by laurentgo <gi...@git.apache.org> on 2016/02/27 02:59:42 UTC

[GitHub] drill pull request: DRILL-4452: Uses Apache Calcite Avatica driver...

GitHub user laurentgo opened a pull request:

    https://github.com/apache/drill/pull/395

    DRILL-4452: Uses Apache Calcite Avatica driver vs Optiq driver for Drill JDBC

    Drill JDBC driver uses Optiq Avatica as its basis, but this dependency has
    been moved over to Calcite, for quite some time without Drill code being
    updated for it.
    
    This patch updates Avatica version to the version from Calcite
    (1.4.0-drill-r10). It also refactors Drill JDBC driver to comply with the
    packages and API changes in Avatica. Finally it fixes the the SQL types for
    lists and structs, since Drill doesn't support java.sql.Array and
    java.sql.Struct interfaces.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/laurentgo/drill laurent/DRILL-4452-use-calcite-avatica

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/395.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #395
    
----
commit 5882507979cc9695261c975a6e77bcdafdf2ca3f
Author: Laurent Goujon <la...@dremio.com>
Date:   2016-02-24T00:00:42Z

    DRILL-4452: Uses Apache Calcite Avatica driver vs Optiq driver for Drill JDBC
    
    Drill JDBC driver uses Optiq Avatica as its basis, but this dependency has
    been moved over to Calcite, for quite some time without Drill code being
    updated for it.
    
    This patch updates Avatica version to the version from Calcite
    (1.4.0-drill-r10). It also refactors Drill JDBC driver to comply with the
    packages and API changes in Avatica. Finally it fixes the the SQL types for
    lists and structs, since Drill doesn't support java.sql.Array and
    java.sql.Struct interfaces.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request #395: DRILL-4452: Uses Apache Calcite Avatica driver vs O...

Posted by vkorukanti <gi...@git.apache.org>.

Github user vkorukanti commented on a diff in the pull request:

    https://github.com/apache/drill/pull/395#discussion_r83089376
  
    --- Diff: exec/jdbc/pom.xml ---
    @@ -21,9 +21,9 @@
     
       <dependencies>
         <dependency>
    -      <groupId>net.hydromatic</groupId>
    -      <artifactId>optiq-avatica</artifactId>
    -      <version>0.9-drill-r20</version>
    +      <groupId>org.apache.calcite</groupId>
    +      <artifactId>calcite-avatica</artifactId>
    +      <version>1.4.0-drill-r10</version>
    --- End diff --
    
    Can we use refactor the version into root pom and use the same version both in jdbc and exec/java-exec?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request: DRILL-4452: Uses Apache Calcite Avatica driver...

Posted by jaltekruse <gi...@git.apache.org>.

Github user jaltekruse commented on the pull request:

    https://github.com/apache/drill/pull/395#issuecomment-193418830
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request #395: DRILL-4452: Uses Apache Calcite Avatica driver vs O...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/drill/pull/395


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---