You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2019/07/25 18:16:11 UTC

[Impala-ASF-CR] IMPALA-8641: Added Zstd to impala file formats.xml 

Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13919


Change subject: IMPALA-8641: Added Zstd to impala_file_formats.xml
......................................................................

IMPALA-8641: Added Zstd to impala_file_formats.xml

Change-Id: I82133b982c472e408d12ce46fc61124627428911
---
M docs/topics/impala_file_formats.xml
1 file changed, 5 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/13919/1
-- 
To view, visit http://gerrit.cloudera.org:8080/13919
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I82133b982c472e408d12ce46fc61124627428911
Gerrit-Change-Number: 13919
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>

[Impala-ASF-CR] IMPALA-8641: Added Zstd to impala file formats.xml

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13919 )

Change subject: IMPALA-8641: Added Zstd to impala_file_formats.xml
......................................................................


Patch Set 2:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/409/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/13919
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I82133b982c472e408d12ce46fc61124627428911
Gerrit-Change-Number: 13919
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Jul 2019 18:37:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8641: Added Zstd to impala file formats.xml

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13919 )

Change subject: IMPALA-8641: Added Zstd to impala_file_formats.xml
......................................................................


Patch Set 1: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/408/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/13919
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I82133b982c472e408d12ce46fc61124627428911
Gerrit-Change-Number: 13919
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Jul 2019 18:40:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8641: Added Zstd to impala file formats.xml

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/13919 )

Change subject: IMPALA-8641: Added Zstd to impala_file_formats.xml
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/13919
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I82133b982c472e408d12ce46fc61124627428911
Gerrit-Change-Number: 13919
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Jul 2019 18:25:33 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8641: Added Zstd to impala file formats.xml

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13919 )

Change subject: IMPALA-8641: Added Zstd to impala_file_formats.xml
......................................................................


Patch Set 1:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/408/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/13919
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I82133b982c472e408d12ce46fc61124627428911
Gerrit-Change-Number: 13919
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Jul 2019 18:16:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8641: Added Zstd to impala file formats.xml

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13919 )

Change subject: IMPALA-8641: Added Zstd to impala_file_formats.xml
......................................................................

IMPALA-8641: Added Zstd to impala_file_formats.xml

Change-Id: I82133b982c472e408d12ce46fc61124627428911
Reviewed-on: http://gerrit.cloudera.org:8080/13919
Reviewed-by: Alex Rodoni <ar...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M docs/topics/impala_file_formats.xml
M docs/topics/impala_parquet.xml
2 files changed, 6 insertions(+), 4 deletions(-)

Approvals:
  Alex Rodoni: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/13919
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I82133b982c472e408d12ce46fc61124627428911
Gerrit-Change-Number: 13919
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-8641: Added Zstd to impala file formats.xml

Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/13919 )

Change subject: IMPALA-8641: Added Zstd to impala_file_formats.xml
......................................................................


Patch Set 1: Code-Review+1

Looks good. Thanks!


-- 
To view, visit http://gerrit.cloudera.org:8080/13919
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I82133b982c472e408d12ce46fc61124627428911
Gerrit-Change-Number: 13919
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Jul 2019 18:23:27 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8641: Added Zstd to impala file formats.xml

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/13919 )

Change subject: IMPALA-8641: Added Zstd to impala_file_formats.xml
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/13919
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I82133b982c472e408d12ce46fc61124627428911
Gerrit-Change-Number: 13919
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Jul 2019 18:37:40 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8641: Added Zstd to impala file formats.xml

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Abhishek Rawat, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13919

to look at the new patch set (#2).

Change subject: IMPALA-8641: Added Zstd to impala_file_formats.xml
......................................................................

IMPALA-8641: Added Zstd to impala_file_formats.xml

Change-Id: I82133b982c472e408d12ce46fc61124627428911
---
M docs/topics/impala_file_formats.xml
M docs/topics/impala_parquet.xml
2 files changed, 6 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/13919/2
-- 
To view, visit http://gerrit.cloudera.org:8080/13919
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I82133b982c472e408d12ce46fc61124627428911
Gerrit-Change-Number: 13919
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-8641: Added Zstd to impala file formats.xml

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13919 )

Change subject: IMPALA-8641: Added Zstd to impala_file_formats.xml
......................................................................


Patch Set 2: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/409/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/13919
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I82133b982c472e408d12ce46fc61124627428911
Gerrit-Change-Number: 13919
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Jul 2019 18:42:14 +0000
Gerrit-HasComments: No