You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2020/10/01 22:42:59 UTC
[GitHub] [thrift] aaronstgeorge-wf opened a new pull request #2251: THRIFT-5285 Update http package + update to dart 2 + stylistic changes
aaronstgeorge-wf opened a new pull request #2251:
URL: https://github.com/apache/thrift/pull/2251
<!-- Explain the changes in the pull request below: -->
http 0.11.x will not build on dart 2. This PR widens the range to include 0.12.x.
Additional non essential changes:
- Dart 1 is now deprecated, this pull request updates thrift dart library to be solely dart 2 compatible.
- Adds some stylistic changes that we at workiva consider to be a good idea.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] aaronstgeorge-wf commented on pull request #2251: THRIFT-5285 Update http package + update to dart 2 + stylistic changes
Posted by GitBox <gi...@apache.org>.
aaronstgeorge-wf commented on pull request #2251:
URL: https://github.com/apache/thrift/pull/2251#issuecomment-740700871
@jeking3 you helped a colleague of mine out on here https://github.com/apache/thrift/pull/1617, any chance you could help me get this in? The remaining failures are in erlang so I don't think anything in this change-set is responsible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G closed pull request #2251: THRIFT-5285 Update http package + update to dart 2 + stylistic changes
Posted by GitBox <gi...@apache.org>.
Jens-G closed pull request #2251:
URL: https://github.com/apache/thrift/pull/2251
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] aaronstgeorge-wf commented on pull request #2251: THRIFT-5285 Update http package + update to dart 2 + stylistic changes
Posted by GitBox <gi...@apache.org>.
aaronstgeorge-wf commented on pull request #2251:
URL: https://github.com/apache/thrift/pull/2251#issuecomment-788067310
@jeking3 or @Jens-G what could I go to get this branch moving? The remaining CI failures are in Erlang and I'm relatively certain were not caused by this change set.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] aaronstgeorge-wf commented on pull request #2251: THRIFT-5285 Update http package + update to dart 2 + stylistic changes
Posted by GitBox <gi...@apache.org>.
aaronstgeorge-wf commented on pull request #2251:
URL: https://github.com/apache/thrift/pull/2251#issuecomment-789040762
Thanks @Jens-G !!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org