You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "lameapparition (via GitHub)" <gi...@apache.org> on 2023/10/24 13:33:58 UTC

[I] TOTALS incorrect for non-additive metric in pivot table [superset]

lameapparition opened a new issue, #25747:
URL: https://github.com/apache/superset/issues/25747

   Hello, I'm new into Superset. Trying to move our analytics to this platform, but i met problem as I see no possibility of making Total row correct for non-countable (or non-additive) metric
   Example:
   I have three metrics grouped by month:
   1. "spend plan" – amount of money company was planning to spend
   2. "spend fact"  – amount of money company actually spended
   3. "spend rate" – ratio of spend fact and spend plan 
   So, I created pivot table and added totals. "spend plan" and "spend fact" are ok – its totals are sums of all values
   but for "spend rate" I also see sums of all values instead of ratio of "spend fact" and "spend plan" totals
   <img width="1415" alt="image" src="https://github.com/apache/superset/assets/108183770/d47cbf45-407d-4555-84df-4038d97f2b12">
   <img width="366" alt="image" src="https://github.com/apache/superset/assets/108183770/b20c64e4-526e-43f3-8b6c-b3f93e4f92b7">
   
   Expected result (using Google Spreadsheets):
   <img width="1176" alt="image" src="https://github.com/apache/superset/assets/108183770/fa0b9f10-79b9-42dc-b582-58935b16432c">
   Maybe I'm missing something, hope to get help
   
   UPD. Found that usual table calculates "spend rate" correctly
   <img width="1412" alt="image" src="https://github.com/apache/superset/assets/108183770/2449e758-e343-4c32-b066-74675961a3c8">
   
   _Originally posted by @lameapparition in https://github.com/apache/superset/issues/14061#issuecomment-1777176807_
               


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] TOTALS incorrect for non-additive metric in pivot table [superset]

Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on issue #25747:
URL: https://github.com/apache/superset/issues/25747#issuecomment-1781814619

   This is a known limitation right now. The solution would be to trigger additional queries for all aggregation levels. By doing so even non-additive metrics would display correctly (this is how the table chart does it). However, the required change is rather complex, and requires good knowledge of how the pivot table chart works. IIRC I've discussed this with @kgabryje a few times a while ago (he's the original author of the chart plugin), but we were never able to find the time to work on implementing this improvement.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] TOTALS incorrect for non-additive metric in pivot table [superset]

Posted by "goldjee (via GitHub)" <gi...@apache.org>.
goldjee commented on issue #25747:
URL: https://github.com/apache/superset/issues/25747#issuecomment-2277285422

   Bumping this because I believe that the ability to aggregate non-additive data is crucial for any BI tool. All of the major tools present on the market can handle that effortlessly.
   
   As we define SQL for measures (and they should be proper SQL aggregates) in dataset options, I think that Superset already has all the required information to calculate subtotals. So,
   
   * For each aggregation level, the pivot table could send a query to the database with properly generated GROUP BY.
   * In chart settings, the dropdown that allows to choose aggregation type can be safely removed.
   
   This approach has an obvious drawback of spamming queries if there is a lot of aggregation levels. But realistically no pivot table would have even a dozen of them, so such an overhead should be tolerable.
   
   @mistercrunch @rusackas @villebro Could we expect such a feature in one of the upcoming releases?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] TOTALS incorrect for non-additive metric in pivot table [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #25747:
URL: https://github.com/apache/superset/issues/25747#issuecomment-4738469860

   Doing some triage housekeeping here. There's a whole constellation of issues describing the same underlying thing: totals/subtotals re-aggregate the already-aggregated cell values, which is just wrong for any non-additive metric (ratios, `AVG`, `COUNT_DISTINCT`, percentiles...). Going to make this the canonical thread, since it's the oldest and most active, and it's what #34592 already targets.
   
   Folding these in, with the net-new context from each:
   - #38674 - same thing on the pivot Grand Total, nicely framed as a ratio metric `SUM(num)/NULLIF(SUM(den),0)`. Also confirmed there's no `ENABLE_BACKEND_PIVOT_TOTALS` flag (that was a red herring), and totals get processed in `superset/charts/client_processing.py`.
   - #32260 - the completion-percentage example, plus a few folks floating an Excel-style in-cell/formula approach (a configurable `round((a/b)*100, 2)` kind of thing) as one possible direction.
   - #37627 - the important one: this is the **Table** chart, not pivot, and it still repros on 6.0.0 (percentage column shows zeros when "Show summary" is on). So the bug lives in the `plugin-chart-table` path too.
   - #34350 / #34425 / #34426 - Table chart percentage totals on 4.1.3. #34425 adds the wrinkle that paginated percentage calcs only use the current page unless you set "Percentage metric calculation" to "All records".
   
   So the scope here is explicitly **both pivot tables and regular table charts** - any real fix needs to cover both code paths. #34592 only handles the pivot side at the moment, FWIW.
   
   Design discussion lives in #29297, and the open question there is still the gate: do we fire a query per aggregation level (#34592's approach, with perf tradeoffs) or go formula-aware? Would love eyes from folks who've been in this code... CC @michael-s-molina @mistercrunch @villebro
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] TOTALS incorrect for non-additive metric in pivot table [superset]

Posted by "rafal-celinski (via GitHub)" <gi...@apache.org>.
rafal-celinski commented on issue #25747:
URL: https://github.com/apache/superset/issues/25747#issuecomment-3163284594

   Hi! I tried to fix this problem and have already uploaded my changes in #34592.
   I deleted aggregate functions and calculate totals by executing multiple, separate queries with varying GROUP BY clauses.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] TOTALS incorrect for non-additive metric in pivot table [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #25747:
URL: https://github.com/apache/superset/issues/25747#issuecomment-2957581903

   This just hit my potential-stale-issue radar, but obviously it's still relevant. I'm not sure whether or not some of the newer solutions @yousoph has been looking into on the Preset side have taken this into account or not. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] TOTALS incorrect for non-additive metric in pivot table [superset]

Posted by "mhgapps (via GitHub)" <gi...@apache.org>.
mhgapps commented on issue #25747:
URL: https://github.com/apache/superset/issues/25747#issuecomment-2688382449

   Really looking forward to see when this will be solved. I am moving from Tableau mainly because I grew tired of how heavy Prep is, and how long it takes to clean all my data sets. Also because is expensive... But net being able to have a pivot table that subtotals both sum and avg is a major issue. In my current setup in Superset I ended up creating 2 tables, one for $$$ and the other one for % but is a pain for layout purposes in the dashboard. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] TOTALS incorrect for non-additive metric in pivot table [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #25747:
URL: https://github.com/apache/superset/issues/25747#issuecomment-5036822845

   SIP-216 passed the process gate and the DB-side rollup POC in #41184 covers both table and pivot totals. This thread will close when that merges... but I'm still seeking reviewers! Please jump in, the water's perfect ;)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] TOTALS incorrect for non-additive metric in pivot table [superset]

Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on issue #25747:
URL: https://github.com/apache/superset/issues/25747#issuecomment-2447767213

   We thought about implementing a mini-language for metrics in the past as some other BI tools do as it would serve other use cases beyond this one. Say if you define a complex metric as a long `SUM(CASE WHEN {...} END)` and would like to reuse it in a ratio or another metric for whatever reason, currently you have to duplicate the logic which is ok but not ideal. 
   
   One approach would be to use the jinja support in place by adding some sort of macro for say `{{ dataset.metrics("my_numerator") }} / {{ dataset.metrics("my_numerator") / }}`, but this wouldn't work for in-frontend-type computation like the use case we're exploring here.
   
   If we were to come up with a higher level mini-language, we'd have the luxury to decide whether to compute on the backend or frontend depending on the use case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] TOTALS incorrect for non-additive metric in pivot table [superset]

Posted by "YuriPP (via GitHub)" <gi...@apache.org>.
YuriPP commented on issue #25747:
URL: https://github.com/apache/superset/issues/25747#issuecomment-2975889527

   Maybe the difference between SuperSet and some other platforms is:
    -   SuperSet calculates totals on the base of rows (vertical path)
    -  Other calculate totals on the base of columns using the formula for the row (horizontal path)
   Example:
   row 1  row2  row3 (SUM(row2)/SUM(row1) *100)
                         SuperSet        Other
           1        1           100           100
          10        4            40             40
         SUM  SUM    AVG() == (SUM(row2)/SUM(row1) *100)
           11        5            70             45
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] TOTALS incorrect for non-additive metric in pivot table [superset]

Posted by "Valerii-Tcvetkov (via GitHub)" <gi...@apache.org>.
Valerii-Tcvetkov commented on issue #25747:
URL: https://github.com/apache/superset/issues/25747#issuecomment-2717341037

   Is it possible to use custom plugin for chart or smth like that? It's pretty strange, that there're no solution yet...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] TOTALS incorrect for non-additive metric in pivot table [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #25747:
URL: https://github.com/apache/superset/issues/25747#issuecomment-2145723331

   Hey all,
   
   Just FYI, we have had quite a few issues on this topic. I've closed out a couple of the other ones in favor of this one. lease feel free to do they same as they arise!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] TOTALS incorrect for non-additive metric in pivot table [superset]

Posted by "ramrajsingh (via GitHub)" <gi...@apache.org>.
ramrajsingh commented on issue #25747:
URL: https://github.com/apache/superset/issues/25747#issuecomment-2446315209

   A better/easier way to implement this ( and that will add an additional feature ) is to implement weighted sum.
   Here in this case while calculating sum ( for rations and %  columns ) we need to weight by the value of denominator column and this weighed sum needs to be normalized/divided by sum of denominator column.
   
   This will effectively give sum(numerator)/sum(denominator)
   
   E.g.
     | Numerator | Denominator | Ratio | Weight (=Denominator) | Weight X Ratio ( Hidden )
   -- | -- | -- | -- | -- | --
     | 10 | 40 | 0.25 | 40 | 10
     | 3 | 80 | 0.0375 | 80 | 3
     | 30 | 50 | 0.6 | 50 | 30
     | 40 | 80 | 0.5 | 80 | 40
     | 35 | 100 | 0.35 | 100 | 35
   Totals | 118 | 350 | 1.7375 | 350 | 118
   
   The total of ratio is 1.7375 is current superset behavior.
   If we implement weighted sum it will be sum of weight*ratio / sum of weights = 118/350 = 0.33714286
   
   From GUI we need to save a dict of which columns sum are weighed and what is/are the corresponding weight column. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] TOTALS incorrect for non-additive metric in pivot table [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #25747:
URL: https://github.com/apache/superset/issues/25747#issuecomment-4813498264

   Update for everyone on this one: I've written it up as a proper SIP, #41463, so we can align on the approach before it goes much further. The gist is computing totals in the database at each grouping level (via `GROUPING SETS` where the engine supports it, with a fallback otherwise) instead of summing already-aggregated cells, covering both the pivot table and the regular table chart.
   
   There's a working POC in #41184 that's verified against Postgres (the classic "completion %" grand total now shows 11% instead of 100%+). Would love thoughts on the SIP before we take it to a vote... CC @michael-s-molina @mistercrunch @villebro
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] TOTALS incorrect for non-additive metric in pivot table [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #25747:
URL: https://github.com/apache/superset/issues/25747#issuecomment-5081461004

   Looks like #41184 handled this when it merged - it names #25747 as the canonical bug it fixes. Closing, but ping me to reopen if the totals still look off.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] TOTALS incorrect for non-additive metric in pivot table [superset]

Posted by "felipegranado (via GitHub)" <gi...@apache.org>.
felipegranado commented on issue #25747:
URL: https://github.com/apache/superset/issues/25747#issuecomment-2223945015

   Hi!
   
   Any update for this? I working in a table and I found same issue about the totals.
   
   Thanks in advance...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] TOTALS incorrect for non-additive metric in pivot table [superset]

Posted by "rishika-ushur (via GitHub)" <gi...@apache.org>.
rishika-ushur commented on issue #25747:
URL: https://github.com/apache/superset/issues/25747#issuecomment-2651115615

   @mistercrunch Are there any updates on this feature yet? Can you please suggest a work around if available


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] TOTALS incorrect for non-additive metric in pivot table [superset]

Posted by "MarcoFranchin96 (via GitHub)" <gi...@apache.org>.
MarcoFranchin96 commented on issue #25747:
URL: https://github.com/apache/superset/issues/25747#issuecomment-2659370826

   Hi, is there any update on this? Because it's a pretty basic behaviour for a BI tool


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] TOTALS incorrect for non-additive metric in pivot table [superset]

Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on issue #25747:
URL: https://github.com/apache/superset/issues/25747#issuecomment-1928500048

   There'd be two main ways to approach this:
   - having different semantics around formulas and an engine that's formula-aware, meaning it could pushdown to SQL or render on the backend/frontend. This may work for ratios or averages, but not for distinct counts or percentiles
   - running multiple queries, one for each aggregation-level. This can get complex if service into sub-totals and multiple dimensions
   
   Both of those would be significant work and add much more complexity to the current SQL-oriented approach.
   
   It could be good though to hide totals for non-additive metrics though, probably through per-metric inference or configuration. If it's a simple metric, we know which aggregation methods are additive and/or why. If it's SQL expression, the user may have to tell us if it's additive or not. A simple quick-fix would be to only show the totals where people use the `SUM`-type simple metric (which is probably 80%+ of metrics out there).
   
   Interestingly, for things like average we could be smarter, and for things like ratio (ask the db for a SUM(col) and a COUNT(col)) and do our own math. For ratio we could introduce new "not-so-simple" metrics where you specify your numerator metric and denominator metric and we could compute totals properly.... 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] TOTALS incorrect for non-additive metric in pivot table [superset]

Posted by "u35253 (via GitHub)" <gi...@apache.org>.
u35253 commented on issue #25747:
URL: https://github.com/apache/superset/issues/25747#issuecomment-3559106829

   # Keep "Total (Sum)" option, but add another "Total (Overall)" option
   
   The current implementation is actually very useful.
   - Sometimes, in Superset, it *is* wanted to validly SUM to get the TOTAL of whatever aggregate values were above. I have use cases of this.
   
   But, after seeing the different "Total" usage (apply same aggregate function to all underlying data), in another tool, now I see why this issue exists.  Some people want to do that, too.
   
   Please consider NOT removing "Total (Sum)" option from Pivot Tables in Superset.
   
   If anything, consider ALSO adding another checkbox, with another label, for the "use the same aggregate" function.  This could be called "Total (Overall)", or "Total (Aggregate)", or "Overall (Aggregate", or "Overall", or something else.
   
   Keep what is there, but also do what other people want.  Please and thank you.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] TOTALS incorrect for non-additive metric in pivot table [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed issue #25747: TOTALS incorrect for non-additive metric in pivot table
URL: https://github.com/apache/superset/issues/25747


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org