You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/01/31 12:09:05 UTC

[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #333: Add failOnFlakeCount option

Tibor17 edited a comment on pull request #333:
URL: https://github.com/apache/maven-surefire/pull/333#issuecomment-770372094


   > 
   > 
   > I would have used that normally, but all the other methods in this test didn't use it either, but instead used the pattern shown here. I generally always go with the pattern that some codebase already uses.
   > 
   > Happy to use ExpectedException. Should I also adjust the other existing methods in this test?
   
   Pls first use `ExpectedException` for your two methods and then squash your commits into one with a name `[SUREFIRE-1878] Add failOnFlakeCount option`.
   Then concentrate on the `ExpectedException` for the other methods and make extra commit.
   +1 LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org