You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "bozhang2820 (via GitHub)" <gi...@apache.org> on 2023/05/24 04:53:34 UTC
[GitHub] [spark] bozhang2820 commented on a diff in pull request #41277: [SPARK-38464][CORE] Use error classes in org.apache.spark.io
bozhang2820 commented on code in PR #41277:
URL: https://github.com/apache/spark/pull/41277#discussion_r1203426212
##########
core/src/main/scala/org/apache/spark/io/CompressionCodec.scala:
##########
@@ -88,8 +88,12 @@ private[spark] object CompressionCodec {
} catch {
case _: ClassNotFoundException | _: IllegalArgumentException => None
}
- codec.getOrElse(throw new IllegalArgumentException(s"Codec [$codecName] is not available. " +
- s"Consider setting $configKey=$FALLBACK_COMPRESSION_CODEC"))
+ codec.getOrElse(throw new SparkIllegalArgumentException(
+ errorClass = "CODEC_NOT_AVAILABLE",
+ messageParameters = Map(
+ "codecName" -> codecName,
+ "configKey" -> configKey,
+ "configVal" -> FALLBACK_COMPRESSION_CODEC)))
Review Comment:
Done.
##########
core/src/main/scala/org/apache/spark/io/CompressionCodec.scala:
##########
@@ -88,8 +88,12 @@ private[spark] object CompressionCodec {
} catch {
case _: ClassNotFoundException | _: IllegalArgumentException => None
}
- codec.getOrElse(throw new IllegalArgumentException(s"Codec [$codecName] is not available. " +
- s"Consider setting $configKey=$FALLBACK_COMPRESSION_CODEC"))
+ codec.getOrElse(throw new SparkIllegalArgumentException(
+ errorClass = "CODEC_NOT_AVAILABLE",
+ messageParameters = Map(
+ "codecName" -> codecName,
+ "configKey" -> configKey,
Review Comment:
Ditto. Should we move these to spark-core? Or have them duplicated?
##########
core/src/main/scala/org/apache/spark/io/CompressionCodec.scala:
##########
@@ -88,8 +88,12 @@ private[spark] object CompressionCodec {
} catch {
case _: ClassNotFoundException | _: IllegalArgumentException => None
}
- codec.getOrElse(throw new IllegalArgumentException(s"Codec [$codecName] is not available. " +
- s"Consider setting $configKey=$FALLBACK_COMPRESSION_CODEC"))
+ codec.getOrElse(throw new SparkIllegalArgumentException(
+ errorClass = "CODEC_NOT_AVAILABLE",
+ messageParameters = Map(
+ "codecName" -> codecName,
Review Comment:
`toSQLValue` is defined in spark-sql, we cannot use it directly here in spark-core.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org