[GitHub] [activemq-artemis] michaelandrepearce edited a comment on pull request #2695: ARTEMIS-2372 Filtering on Message Annotations

[GitBox <gi...@apache.org>]

michaelandrepearce edited a comment on pull request #2695:
URL: https://github.com/apache/activemq-artemis/pull/2695#issuecomment-624947711


   I have to agree with Cleberts earlier comment amqp 1.0 was not meant to care if a sender or receiver is a broker, its agnostic. As such it really shouldnt be enforcing any broker specifics, by doing so it no longer is an agnostic protocol.
   
   That said and it seems we have two camps in general here, those that are wanting strict conformist and thats important for their use case and those who need broker features that technically break strict conformance but for some users actually have business value for them such this filter ability in this pr and in other prs where sometimes to have a broker feature requires mutating (adding or amending) some amqp sections. 
   
   Could i suggest we have a broker flag in config that is called maybe "amqpConformance" where its set to STRICT or RELAXED, and going forwards when hit these issue simply use the flag to still allow it should end broker users wish to enable the RELAXED operation mode thats their prerogative.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org