You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/07/23 02:25:40 UTC
[GitHub] [spark] zhengruifeng commented on issue #25178: [SPARK-28421][ML]
SparseVector.apply performance optimization
zhengruifeng commented on issue #25178: [SPARK-28421][ML] SparseVector.apply performance optimization
URL: https://github.com/apache/spark/pull/25178#issuecomment-514027613
I added the extra range check just because in `breeze.collection.mutable.SparseArray`, the `findOffset` function does this and comments `special case for end of list - this is a big win for growing sparse arrays`
@srowen @dongjoon-hyun @kiszk I will do anothe simple test to find whether the extra range chek helps.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org