You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "dongxuwang (via GitHub)" <gi...@apache.org> on 2023/08/12 13:50:51 UTC
[GitHub] [incubator-pekko] dongxuwang opened a new pull request, #565: improve scaladoc for DoNotInherit
dongxuwang opened a new pull request, #565:
URL: https://github.com/apache/incubator-pekko/pull/565
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #565: improve scaladoc for DoNotInherit
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #565:
URL: https://github.com/apache/incubator-pekko/pull/565#issuecomment-1679247566
merged - thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin commented on a diff in pull request #565: improve scaladoc for DoNotInherit
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #565:
URL: https://github.com/apache/incubator-pekko/pull/565#discussion_r1294669709
##########
actor/src/main/java/org/apache/pekko/annotation/DoNotInherit.java:
##########
@@ -16,14 +16,14 @@
import java.lang.annotation.*;
/**
- * Marks APIs that are designed under an closed-world assumption for and are NOT meant to be
+ * Marks APIs that are designed under a closed-world assumption for and are NOT meant to be
* extended by user-code. It is fine to extend these classes within Apache Pekko itself, however.
*
* <p>This is most useful for binary compatibility purposes when a set of classes and interfaces
* assume a "closed world" between them, and gain the ability to add methods to the interfaces
* without breaking binary compatibility for users of this code. Specifically this assumption may be
* understood intuitively: as all classes that implement this interface are in this compilation unit
- * / artifact, it is impossible to obtain a "old" class with a "new" interface, as they are part of
+ * / artifact, it is impossible to obtain an "old" class with a "new" interface, as they are part of
Review Comment:
need a `javafmtAll`.
##########
actor/src/main/java/org/apache/pekko/annotation/DoNotInherit.java:
##########
@@ -16,14 +16,14 @@
import java.lang.annotation.*;
/**
- * Marks APIs that are designed under an closed-world assumption for and are NOT meant to be
+ * Marks APIs that are designed under a closed-world assumption for and are NOT meant to be
* extended by user-code. It is fine to extend these classes within Apache Pekko itself, however.
*
* <p>This is most useful for binary compatibility purposes when a set of classes and interfaces
* assume a "closed world" between them, and gain the ability to add methods to the interfaces
* without breaking binary compatibility for users of this code. Specifically this assumption may be
* understood intuitively: as all classes that implement this interface are in this compilation unit
- * / artifact, it is impossible to obtain a "old" class with a "new" interface, as they are part of
+ * / artifact, it is impossible to obtain an "old" class with a "new" interface, as they are part of
Review Comment:
need to run `javafmtAll`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning merged pull request #565: improve scaladoc for DoNotInherit
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #565:
URL: https://github.com/apache/incubator-pekko/pull/565
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org