You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/10 02:15:27 UTC
[GitHub] [pulsar] Shawyeok opened a new pull request #14635: Change "Could not split namespace bundle" logging level to info
Shawyeok opened a new pull request #14635:
URL: https://github.com/apache/pulsar/pull/14635
### Motivation
There are so many WARN log about `Could not split namespace bundle {} because namespace {} has too many bundles: {}`, it may disturb WARN log alarm.
### Modifications
Change to `INFO` level.
### Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
- [ ] `doc-required`
(If you need help on updating docs, create a doc issue)
- [x] `no-need-doc`
- [ ] `doc`
(If this PR contains doc changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #14635: Change "Could not split namespace bundle" logging level to info
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on a change in pull request #14635:
URL: https://github.com/apache/pulsar/pull/14635#discussion_r826308436
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/BundleSplitterTask.java
##########
@@ -94,7 +94,7 @@ public BundleSplitterTask() {
if (bundleCount < maxBundleCount) {
bundleCache.add(bundle);
} else {
- log.warn(
+ log.info(
Review comment:
Can we make this a `debug` log? This feels like debug information, considering there isn't really an action for the end user, unless they want to increase their bundle limit. Operators can easily determine the number of bundles for the namespace at any time.
cc @merlimat @codelipenghui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #14635: Change "Could not split namespace bundle" logging level to info
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on a change in pull request #14635:
URL: https://github.com/apache/pulsar/pull/14635#discussion_r826308436
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/BundleSplitterTask.java
##########
@@ -94,7 +94,7 @@ public BundleSplitterTask() {
if (bundleCount < maxBundleCount) {
bundleCache.add(bundle);
} else {
- log.warn(
+ log.info(
Review comment:
Can we make this a `debug` log? This feels like debug information, considering there isn't really an action for the end user, unless they want to increase their bundle limit. Operators can easily determine the number of bundles for the namespace at any time via the admin API. When there are a lot of namespaces, as @Shawyeok's logs show, it seems like this is spam, even at the `info` level.
cc @merlimat @codelipenghui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #14635: Change "Could not split namespace bundle" logging level to info
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on a change in pull request #14635:
URL: https://github.com/apache/pulsar/pull/14635#discussion_r826318146
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/BundleSplitterTask.java
##########
@@ -94,7 +94,7 @@ public BundleSplitterTask() {
if (bundleCount < maxBundleCount) {
bundleCache.add(bundle);
} else {
- log.warn(
+ log.info(
Review comment:
I created https://github.com/apache/pulsar/pull/14683 to continue this discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shawyeok commented on pull request #14635: Change "Could not split namespace bundle" logging level to info
Posted by GitBox <gi...@apache.org>.
Shawyeok commented on pull request #14635:
URL: https://github.com/apache/pulsar/pull/14635#issuecomment-1063582812
@codelipenghui PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat merged pull request #14635: Change "Could not split namespace bundle" logging level to info
Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #14635:
URL: https://github.com/apache/pulsar/pull/14635
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org