You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2015/08/27 02:37:49 UTC
Review Request 37824: mesos: Updates for google-glog upgrade to 0.3.4
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37824/
-----------------------------------------------------------
Review request for mesos.
Bugs: MESOS-3322
https://issues.apache.org/jira/browse/MESOS-3322
Repository: mesos
Description
-------
See MESOS-3322.
Diffs
-----
LICENSE c3aaa437af10533132698df3348114195d338965
src/python/native/ext_modules.py.in 4682e5eed0f7be23fb48ef628e1bebc7741431d7
Diff: https://reviews.apache.org/r/37824/diff/
Testing
-------
Thanks,
Neil Conway
Re: Review Request 37824: mesos: Updates for google-glog upgrade to 0.3.4
Posted by Neil Conway <ne...@gmail.com>.
On Wed, Aug 26, 2015 at 6:37 PM, Mesos ReviewBot
<re...@mesos.apache.org> wrote:
> Failed command: ./support/apply-review.sh -n -r 37823
>
> Error:
> 2015-08-27 01:37:49 URL:https://reviews.apache.org/r/37823/diff/raw/ [9017/9017] -> "37823.patch" [1]
> error: missing binary patch data for '3rdparty/libprocess/3rdparty/glog-0.3.4.tar.gz'
> error: binary patch does not apply to '3rdparty/libprocess/3rdparty/glog-0.3.4.tar.gz'
> error: 3rdparty/libprocess/3rdparty/glog-0.3.4.tar.gz: patch does not apply
> Failed to apply patch
Weird; running that command locally works fine:
./support/apply-review.sh -n -r 37823
2015-08-26 19:25:05 URL:https://reviews.apache.org/r/37823/diff/raw/
[9017/9017] -> "37823.patch" [1]
Successfully applied: libprocess: Update vendored copy of google-glog to 0.3.4
This means we no longer need to apply a custom patch to glog.
Fixes MESOS-3322.
Review: https://reviews.apache.org/r/37823
No files to lint
[master 582cb8f] libprocess: Update vendored copy of google-glog to 0.3.4
Author: Neil Conway <ne...@gmail.com>
7 files changed, 4 insertions(+), 152 deletions(-)
delete mode 100644 3rdparty/libprocess/3rdparty/glog-0.3.3.patch
delete mode 100644 3rdparty/libprocess/3rdparty/glog-0.3.3.tar.gz
create mode 100644 3rdparty/libprocess/3rdparty/glog-0.3.4.tar.gz
Neil
Re: Review Request 37824: mesos: Updates for google-glog upgrade to
0.3.4
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37824/#review96624
-----------------------------------------------------------
Bad patch!
Reviews applied: [37823]
Failed command: ./support/apply-review.sh -n -r 37823
Error:
2015-08-27 01:37:49 URL:https://reviews.apache.org/r/37823/diff/raw/ [9017/9017] -> "37823.patch" [1]
error: missing binary patch data for '3rdparty/libprocess/3rdparty/glog-0.3.4.tar.gz'
error: binary patch does not apply to '3rdparty/libprocess/3rdparty/glog-0.3.4.tar.gz'
error: 3rdparty/libprocess/3rdparty/glog-0.3.4.tar.gz: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Aug. 27, 2015, 12:37 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37824/
> -----------------------------------------------------------
>
> (Updated Aug. 27, 2015, 12:37 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-3322
> https://issues.apache.org/jira/browse/MESOS-3322
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See MESOS-3322.
>
>
> Diffs
> -----
>
> LICENSE c3aaa437af10533132698df3348114195d338965
> src/python/native/ext_modules.py.in 4682e5eed0f7be23fb48ef628e1bebc7741431d7
>
> Diff: https://reviews.apache.org/r/37824/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 37824: mesos: Updates for google-glog upgrade to
0.3.4
Posted by Niklas Nielsen <ni...@qni.dk>.
> On Aug. 27, 2015, 1:27 p.m., Mesos ReviewBot wrote:
> > Bad patch!
> >
> > Reviews applied: [37823]
> >
> > Failed command: ./support/apply-review.sh -n -r 37823
> >
> > Error:
> > 2015-08-27 20:25:09 URL:https://reviews.apache.org/r/37823/diff/raw/ [9017/9017] -> "37823.patch" [1]
> > error: missing binary patch data for '3rdparty/libprocess/3rdparty/glog-0.3.4.tar.gz'
> > error: binary patch does not apply to '3rdparty/libprocess/3rdparty/glog-0.3.4.tar.gz'
> > error: 3rdparty/libprocess/3rdparty/glog-0.3.4.tar.gz: patch does not apply
> > Failed to apply patch
Hi Neil, maybe you need to make an explicit diff with --binary
- Niklas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37824/#review96747
-----------------------------------------------------------
On Aug. 27, 2015, 1:11 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37824/
> -----------------------------------------------------------
>
> (Updated Aug. 27, 2015, 1:11 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-3322
> https://issues.apache.org/jira/browse/MESOS-3322
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See MESOS-3322.
>
>
> Diffs
> -----
>
> LICENSE c3aaa437af10533132698df3348114195d338965
> src/python/native/ext_modules.py.in 4682e5eed0f7be23fb48ef628e1bebc7741431d7
> support/mesos-style.py 66b45692c3c04f68358b63d52e4d87934f241bd7
>
> Diff: https://reviews.apache.org/r/37824/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 37824: mesos: Updates for google-glog upgrade to
0.3.4
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37824/#review96747
-----------------------------------------------------------
Bad patch!
Reviews applied: [37823]
Failed command: ./support/apply-review.sh -n -r 37823
Error:
2015-08-27 20:25:09 URL:https://reviews.apache.org/r/37823/diff/raw/ [9017/9017] -> "37823.patch" [1]
error: missing binary patch data for '3rdparty/libprocess/3rdparty/glog-0.3.4.tar.gz'
error: binary patch does not apply to '3rdparty/libprocess/3rdparty/glog-0.3.4.tar.gz'
error: 3rdparty/libprocess/3rdparty/glog-0.3.4.tar.gz: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Aug. 27, 2015, 8:11 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37824/
> -----------------------------------------------------------
>
> (Updated Aug. 27, 2015, 8:11 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-3322
> https://issues.apache.org/jira/browse/MESOS-3322
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See MESOS-3322.
>
>
> Diffs
> -----
>
> LICENSE c3aaa437af10533132698df3348114195d338965
> src/python/native/ext_modules.py.in 4682e5eed0f7be23fb48ef628e1bebc7741431d7
> support/mesos-style.py 66b45692c3c04f68358b63d52e4d87934f241bd7
>
> Diff: https://reviews.apache.org/r/37824/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 37824: mesos: Updates for google-glog upgrade to
0.3.4
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37824/
-----------------------------------------------------------
(Updated Aug. 27, 2015, 8:11 p.m.)
Review request for mesos.
Bugs: MESOS-3322
https://issues.apache.org/jira/browse/MESOS-3322
Repository: mesos
Description
-------
See MESOS-3322.
Diffs (updated)
-----
LICENSE c3aaa437af10533132698df3348114195d338965
src/python/native/ext_modules.py.in 4682e5eed0f7be23fb48ef628e1bebc7741431d7
support/mesos-style.py 66b45692c3c04f68358b63d52e4d87934f241bd7
Diff: https://reviews.apache.org/r/37824/diff/
Testing
-------
Thanks,
Neil Conway