You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Mykhailo Kysliuk <mi...@gmail.com> on 2018/06/04 13:46:59 UTC

Review Request 67436: HIVE-19582: NPE during CREATE ROLE using SQL Standard Based Hive Authorization

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67436/
-----------------------------------------------------------

Review request for hive, Ashutosh Chauhan, Eugene Koifman, and Thejas Nair.


Repository: hive-git


Description
-------

Initial commit


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 6c56212 
  ql/src/test/org/apache/hadoop/hive/ql/session/TestSessionState.java 0fa1c81 
  ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFLoggedInUser.java PRE-CREATION 
  ql/src/test/queries/clientpositive/udf_logged_in_user.q c9a6370 
  ql/src/test/results/clientpositive/udf_logged_in_user.q.out da8b894 


Diff: https://reviews.apache.org/r/67436/diff/1/


Testing
-------


Thanks,

Mykhailo Kysliuk


Re: Review Request 67436: HIVE-19582: NPE during CREATE ROLE using SQL Standard Based Hive Authorization

Posted by Mykhailo Kysliuk <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67436/
-----------------------------------------------------------

(Updated June 6, 2018, 11:35 a.m.)


Review request for hive, Ashutosh Chauhan, Eugene Koifman, and Thejas Nair.


Changes
-------

Checkstyle violations fixed


Repository: hive-git


Description
-------

Checkstyle fixed


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 6c56212 
  ql/src/test/org/apache/hadoop/hive/ql/session/TestSessionState.java 0fa1c81 
  ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFLoggedInUser.java PRE-CREATION 
  ql/src/test/queries/clientpositive/udf_logged_in_user.q c9a6370 
  ql/src/test/results/clientpositive/udf_logged_in_user.q.out da8b894 


Diff: https://reviews.apache.org/r/67436/diff/2/


Testing
-------


Thanks,

Mykhailo Kysliuk


Re: Review Request 67436: HIVE-19582: NPE during CREATE ROLE using SQL Standard Based Hive Authorization

Posted by Mykhailo Kysliuk <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67436/
-----------------------------------------------------------

(Updated June 5, 2018, 2:01 p.m.)


Review request for hive, Ashutosh Chauhan, Eugene Koifman, and Thejas Nair.


Repository: hive-git


Description
-------

Checkstyle fixed


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 6c56212 
  ql/src/test/org/apache/hadoop/hive/ql/session/TestSessionState.java 0fa1c81 
  ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFLoggedInUser.java PRE-CREATION 
  ql/src/test/queries/clientpositive/udf_logged_in_user.q c9a6370 
  ql/src/test/results/clientpositive/udf_logged_in_user.q.out da8b894 


Diff: https://reviews.apache.org/r/67436/diff/2/

Changes: https://reviews.apache.org/r/67436/diff/1-2/


Testing
-------


File Attachments
----------------

HIVE-19582.03.patch
  https://reviews.apache.org/media/uploaded/files/2018/06/05/c0424e08-b6e1-44dc-8f98-cf3dcedaa163__HIVE-19582.03.patch


Thanks,

Mykhailo Kysliuk


Re: Review Request 67436: HIVE-19582: NPE during CREATE ROLE using SQL Standard Based Hive Authorization

Posted by Mykhailo Kysliuk <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67436/
-----------------------------------------------------------

(Updated June 5, 2018, 1:55 p.m.)


Review request for hive, Ashutosh Chauhan, Eugene Koifman, and Thejas Nair.


Repository: hive-git


Description (updated)
-------

Checkstyle fixed


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 6c56212 
  ql/src/test/org/apache/hadoop/hive/ql/session/TestSessionState.java 0fa1c81 
  ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFLoggedInUser.java PRE-CREATION 
  ql/src/test/queries/clientpositive/udf_logged_in_user.q c9a6370 
  ql/src/test/results/clientpositive/udf_logged_in_user.q.out da8b894 


Diff: https://reviews.apache.org/r/67436/diff/1/


Testing
-------


File Attachments (updated)
----------------

HIVE-19582.03.patch
  https://reviews.apache.org/media/uploaded/files/2018/06/05/c0424e08-b6e1-44dc-8f98-cf3dcedaa163__HIVE-19582.03.patch


Thanks,

Mykhailo Kysliuk