You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/02/19 20:20:05 UTC
[GitHub] [incubator-mxnet] access2rohit opened a new pull request #19930: [BACKPORT]Enable CUDA 11.0 on nightly development builds (#19295)
access2rohit opened a new pull request #19930:
URL: https://github.com/apache/incubator-mxnet/pull/19930
Remove CUDA 9.2 and CUDA 10.0
Backport #19295 as a part of effort #19911
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 merged pull request #19930: [BACKPORT]Enable CUDA 11.0 on nightly + CUDA 11.2 on pip (#19295)(#19764)
Posted by GitBox <gi...@apache.org>.
Zha0q1 merged pull request #19930:
URL: https://github.com/apache/incubator-mxnet/pull/19930
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on pull request #19930: [BACKPORT]Enable CUDA 11.0 on nightly + CUDA 11.2 on pip (#19295)(#19764)
Posted by GitBox <gi...@apache.org>.
access2rohit commented on pull request #19930:
URL: https://github.com/apache/incubator-mxnet/pull/19930#issuecomment-784544736
@leezu @szha @josephevans please review
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] josephevans commented on a change in pull request #19930: [BACKPORT]Enable CUDA 11.0 on nightly + CUDA 11.2 on pip (#19295)(#19764)
Posted by GitBox <gi...@apache.org>.
josephevans commented on a change in pull request #19930:
URL: https://github.com/apache/incubator-mxnet/pull/19930#discussion_r581430048
##########
File path: tools/pip/doc/CU112_ADDITIONAL.md
##########
@@ -20,10 +20,10 @@ Prerequisites
This package supports Linux and Windows platforms. You may also want to check:
- [mxnet-cu110](https://pypi.python.org/pypi/mxnet-cu110/) with CUDA-11.0 support.
Review comment:
Got it. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #19930: [BACKPORT]Enable CUDA 11.0 on nightly + CUDA 11.2 on pip (#19295)(#19764)
Posted by GitBox <gi...@apache.org>.
access2rohit commented on a change in pull request #19930:
URL: https://github.com/apache/incubator-mxnet/pull/19930#discussion_r581427159
##########
File path: tools/pip/doc/CU112_ADDITIONAL.md
##########
@@ -20,10 +20,10 @@ Prerequisites
This package supports Linux and Windows platforms. You may also want to check:
- [mxnet-cu110](https://pypi.python.org/pypi/mxnet-cu110/) with CUDA-11.0 support.
Review comment:
We don't need it since this line actually tells about other variants that user may want to check out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on a change in pull request #19930: [BACKPORT]Enable CUDA 11.0 on nightly development builds (#19295)
Posted by GitBox <gi...@apache.org>.
leezu commented on a change in pull request #19930:
URL: https://github.com/apache/incubator-mxnet/pull/19930#discussion_r579912811
##########
File path: ci/docker/docker-compose.yml
##########
@@ -0,0 +1,242 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# We use the cache_from feature introduced in file form version 3.4 (released 2017-11-01)
Review comment:
The docker-compose is used for setting up the templated Dockerfiles (same Dockerfile, but support different base images with or without nvidia drivers). It has better caching support than the previous `COPY` then `RUN` implementation and may be easier to maintain. It's possible to backport it. You can decide
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #19930: [BACKPORT]Enable CUDA 11.0 on nightly + CUDA 11.2 on pip (#19295)(#19764)
Posted by GitBox <gi...@apache.org>.
access2rohit commented on a change in pull request #19930:
URL: https://github.com/apache/incubator-mxnet/pull/19930#discussion_r582175221
##########
File path: cd/utils/test_artifact_repository.py
##########
@@ -178,11 +178,11 @@ def test_probe_variant_cpu(self, mock_features):
@patch('artifact_repository.get_cuda_version')
def test_probe_variant_cuda(self, mock_cuda_version, mock_features):
"""
- Tests 'cu102' is returned if MKLDNN is OFF and CUDA is ON and CUDA version is 10.2
+ Tests 'cu100' is returned if MKLDNN is OFF and CUDA is ON and CUDA version is 10.0
"""
mock_features.return_value = {'MKLDNN': True, 'CUDA': True}
- mock_cuda_version.return_value = '102'
- self.assertEqual(probe_mxnet_variant('libmxnet.so'), 'cu102')
+ mock_cuda_version.return_value = '100'
+ self.assertEqual(probe_mxnet_variant('libmxnet.so'), 'cu100')
Review comment:
This basically tests for CUDA version on the generated binary from CD pipeline
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] waytrue17 commented on a change in pull request #19930: [BACKPORT]Enable CUDA 11.0 on nightly development builds (#19295)
Posted by GitBox <gi...@apache.org>.
waytrue17 commented on a change in pull request #19930:
URL: https://github.com/apache/incubator-mxnet/pull/19930#discussion_r579580566
##########
File path: ci/docker/docker-compose.yml
##########
@@ -0,0 +1,242 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# We use the cache_from feature introduced in file form version 3.4 (released 2017-11-01)
Review comment:
Seems we don't have `docker-compose.yml` in v1.x currently. Do we need to backport this file?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #19930: [BACKPORT]Enable CUDA 11.0 on nightly + CUDA 11.2 on pip (#19295)(#19764)
Posted by GitBox <gi...@apache.org>.
access2rohit commented on a change in pull request #19930:
URL: https://github.com/apache/incubator-mxnet/pull/19930#discussion_r581427512
##########
File path: ci/docker/Dockerfile.build2.ubuntu_gpu_cu112
##########
@@ -0,0 +1,44 @@
+# -*- mode: dockerfile -*-
Review comment:
copy paste problems with eclipse :P
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] josephevans commented on a change in pull request #19930: [BACKPORT]Enable CUDA 11.0 on nightly + CUDA 11.2 on pip (#19295)(#19764)
Posted by GitBox <gi...@apache.org>.
josephevans commented on a change in pull request #19930:
URL: https://github.com/apache/incubator-mxnet/pull/19930#discussion_r580685933
##########
File path: ci/docker/docker-compose.yml
##########
@@ -0,0 +1,225 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Review comment:
We don't need docker-compose.yml in v1.x branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #19930: [BACKPORT]Enable CUDA 11.0 on nightly development builds (#19295)
Posted by GitBox <gi...@apache.org>.
access2rohit commented on a change in pull request #19930:
URL: https://github.com/apache/incubator-mxnet/pull/19930#discussion_r580629887
##########
File path: ci/docker/docker-compose.yml
##########
@@ -0,0 +1,242 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# We use the cache_from feature introduced in file form version 3.4 (released 2017-11-01)
Review comment:
@leezu since we are not back porting every change back to v1.x from master. I think we can skip it. wdyt ?
If we want to templatize it in this PR we may have to remove most of dockerfiles here: https://github.com/apache/incubator-mxnet/tree/v1.x/ci/docker
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #19930: [BACKPORT]Enable CUDA 11.0 on nightly + CUDA 11.2 on pip (#19295)(#19764)
Posted by GitBox <gi...@apache.org>.
access2rohit commented on a change in pull request #19930:
URL: https://github.com/apache/incubator-mxnet/pull/19930#discussion_r582175221
##########
File path: cd/utils/test_artifact_repository.py
##########
@@ -178,11 +178,11 @@ def test_probe_variant_cpu(self, mock_features):
@patch('artifact_repository.get_cuda_version')
def test_probe_variant_cuda(self, mock_cuda_version, mock_features):
"""
- Tests 'cu102' is returned if MKLDNN is OFF and CUDA is ON and CUDA version is 10.2
+ Tests 'cu100' is returned if MKLDNN is OFF and CUDA is ON and CUDA version is 10.0
"""
mock_features.return_value = {'MKLDNN': True, 'CUDA': True}
- mock_cuda_version.return_value = '102'
- self.assertEqual(probe_mxnet_variant('libmxnet.so'), 'cu102')
+ mock_cuda_version.return_value = '100'
+ self.assertEqual(probe_mxnet_variant('libmxnet.so'), 'cu100')
Review comment:
This basically mocks the CUDA version for a test that checks for cuda version
##########
File path: cd/utils/artifact_repository.md
##########
@@ -17,7 +17,7 @@
# Artifact Repository - Pushing and Pulling libmxnet
-The artifact repository is an S3 bucket accessible only to restricted Jenkins nodes. It is used to store compiled MXNet artifacts that can be used by downstream CD pipelines to package the compiled libraries for different delivery channels (e.g. DockerHub, PyPI, Maven, etc.). The S3 object keys for the files being posted will be prefixed with the following distinguishing characteristics of the binary: branch, commit id, operating system, variant and dependency linking strategy (static or dynamic). For instance, s3://bucket/73b29fa90d3eac0b1fae403b7583fdd1529942dc/ubuntu16.04/cu92mkl/static/libmxnet.so
+The artifact repository is an S3 bucket accessible only to restricted Jenkins nodes. It is used to store compiled MXNet artifacts that can be used by downstream CD pipelines to package the compiled libraries for different delivery channels (e.g. DockerHub, PyPI, Maven, etc.). The S3 object keys for the files being posted will be prefixed with the following distinguishing characteristics of the binary: branch, commit id, operating system, variant and dependency linking strategy (static or dynamic). For instance, s3://bucket/73b29fa90d3eac0b1fae403b7583fdd1529942dc/ubuntu16.04/cu100mkl/static/libmxnet.so
Review comment:
updated now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on pull request #19930: [BACKPORT]Enable CUDA 11.0 on nightly + CUDA 11.2 on pip (#19295)(#19764)
Posted by GitBox <gi...@apache.org>.
access2rohit commented on pull request #19930:
URL: https://github.com/apache/incubator-mxnet/pull/19930#issuecomment-786307977
> the base image `nvidia/cuda:11.2-cudnn8-devel-ubuntu16.04` does not exist, so we probably need to try another image
Checked https://hub.docker.com/r/nvidia/cuda `11.2.1-cudnn8-devel-ubuntu16.04` exists so `nvidia/cuda:11.2.1-cudnn8-devel-ubuntu16.04` should work
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on a change in pull request #19930: [BACKPORT]Enable CUDA 11.0 on nightly + CUDA 11.2 on pip (#19295)(#19764)
Posted by GitBox <gi...@apache.org>.
leezu commented on a change in pull request #19930:
URL: https://github.com/apache/incubator-mxnet/pull/19930#discussion_r582401377
##########
File path: cd/utils/test_artifact_repository.py
##########
@@ -178,11 +178,11 @@ def test_probe_variant_cpu(self, mock_features):
@patch('artifact_repository.get_cuda_version')
def test_probe_variant_cuda(self, mock_cuda_version, mock_features):
"""
- Tests 'cu102' is returned if MKLDNN is OFF and CUDA is ON and CUDA version is 10.2
+ Tests 'cu100' is returned if MKLDNN is OFF and CUDA is ON and CUDA version is 10.0
"""
mock_features.return_value = {'MKLDNN': True, 'CUDA': True}
- mock_cuda_version.return_value = '102'
- self.assertEqual(probe_mxnet_variant('libmxnet.so'), 'cu102')
+ mock_cuda_version.return_value = '100'
+ self.assertEqual(probe_mxnet_variant('libmxnet.so'), 'cu100')
Review comment:
Yes, but I'm trying to understand why you changed the version? In any case, it's just a question and we can merge the PR nevertheless
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] josephevans commented on a change in pull request #19930: [BACKPORT]Enable CUDA 11.0 on nightly + CUDA 11.2 on pip (#19295)(#19764)
Posted by GitBox <gi...@apache.org>.
josephevans commented on a change in pull request #19930:
URL: https://github.com/apache/incubator-mxnet/pull/19930#discussion_r581424927
##########
File path: tools/pip/doc/CU112_ADDITIONAL.md
##########
@@ -20,10 +20,10 @@ Prerequisites
This package supports Linux and Windows platforms. You may also want to check:
- [mxnet-cu110](https://pypi.python.org/pypi/mxnet-cu110/) with CUDA-11.0 support.
Review comment:
Since this file is for cuda 11.2, we should have a line here for 11.2.
##########
File path: ci/docker/Dockerfile.build2.ubuntu_gpu_cu111
##########
@@ -0,0 +1,44 @@
+# -*- mode: dockerfile -*-
Review comment:
Is this the correct name for the dockerfile? Why does it contain "build2" instead of just "build"?
##########
File path: ci/docker/Dockerfile.build2.ubuntu_gpu_cu112
##########
@@ -0,0 +1,44 @@
+# -*- mode: dockerfile -*-
Review comment:
Is this the correct name for the dockerfile? Why does it contain "build2" instead of just "build"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 commented on pull request #19930: [BACKPORT]Enable CUDA 11.0 on nightly + CUDA 11.2 on pip (#19295)(#19764)
Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on pull request #19930:
URL: https://github.com/apache/incubator-mxnet/pull/19930#issuecomment-786300299
the base image `nvidia/cuda:11.2-cudnn8-devel-ubuntu16.04` does not exist, so we probably need to try another image
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on pull request #19930: [BACKPORT]Enable CUDA 11.0 on nightly + CUDA 11.2 on pip (#19295)(#19764)
Posted by GitBox <gi...@apache.org>.
access2rohit commented on pull request #19930:
URL: https://github.com/apache/incubator-mxnet/pull/19930#issuecomment-784547891
@waytrue17 can you review too ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #19930: [BACKPORT]Enable CUDA 11.0 on nightly + CUDA 11.2 on pip (#19295)(#19764)
Posted by GitBox <gi...@apache.org>.
access2rohit commented on a change in pull request #19930:
URL: https://github.com/apache/incubator-mxnet/pull/19930#discussion_r581427443
##########
File path: ci/docker/Dockerfile.build2.ubuntu_gpu_cu111
##########
@@ -0,0 +1,44 @@
+# -*- mode: dockerfile -*-
Review comment:
copy paste problems with eclipse :P
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on pull request #19930: [BACKPORT]Enable CUDA 11.0 on nightly + CUDA 11.2 on pip (#19295)(#19764)
Posted by GitBox <gi...@apache.org>.
access2rohit commented on pull request #19930:
URL: https://github.com/apache/incubator-mxnet/pull/19930#issuecomment-785481524
blocked on unix-GPU failing due to error
```
docker: Error response from daemon: OCI runtime create failed: container_linux.go:370: starting container process caused: process_linux.go:459: container init caused: Running hook #0:: error running hook: exit status 1, stdout: , stderr: nvidia-container-cli: initialization error: nvml error: driver/library version mismatch: unknown.
```
@Zha0q1 @josephevans are looking into this issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on a change in pull request #19930: [BACKPORT]Enable CUDA 11.0 on nightly + CUDA 11.2 on pip (#19295)(#19764)
Posted by GitBox <gi...@apache.org>.
leezu commented on a change in pull request #19930:
URL: https://github.com/apache/incubator-mxnet/pull/19930#discussion_r581587231
##########
File path: cd/utils/test_artifact_repository.py
##########
@@ -178,11 +178,11 @@ def test_probe_variant_cpu(self, mock_features):
@patch('artifact_repository.get_cuda_version')
def test_probe_variant_cuda(self, mock_cuda_version, mock_features):
"""
- Tests 'cu102' is returned if MKLDNN is OFF and CUDA is ON and CUDA version is 10.2
+ Tests 'cu100' is returned if MKLDNN is OFF and CUDA is ON and CUDA version is 10.0
"""
mock_features.return_value = {'MKLDNN': True, 'CUDA': True}
- mock_cuda_version.return_value = '102'
- self.assertEqual(probe_mxnet_variant('libmxnet.so'), 'cu102')
+ mock_cuda_version.return_value = '100'
+ self.assertEqual(probe_mxnet_variant('libmxnet.so'), 'cu100')
Review comment:
What's the purpose of this change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19930: [BACKPORT]Enable CUDA 11.0 on nightly development builds (#19295)
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19930:
URL: https://github.com/apache/incubator-mxnet/pull/19930#issuecomment-782318106
Hey @access2rohit , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [windows-gpu, windows-cpu, clang, website, unix-gpu, unix-cpu, edge, miscellaneous, centos-gpu, centos-cpu, sanity]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] josephevans commented on a change in pull request #19930: [BACKPORT]Enable CUDA 11.0 on nightly + CUDA 11.2 on pip (#19295)(#19764)
Posted by GitBox <gi...@apache.org>.
josephevans commented on a change in pull request #19930:
URL: https://github.com/apache/incubator-mxnet/pull/19930#discussion_r581565777
##########
File path: cd/utils/artifact_repository.md
##########
@@ -17,7 +17,7 @@
# Artifact Repository - Pushing and Pulling libmxnet
-The artifact repository is an S3 bucket accessible only to restricted Jenkins nodes. It is used to store compiled MXNet artifacts that can be used by downstream CD pipelines to package the compiled libraries for different delivery channels (e.g. DockerHub, PyPI, Maven, etc.). The S3 object keys for the files being posted will be prefixed with the following distinguishing characteristics of the binary: branch, commit id, operating system, variant and dependency linking strategy (static or dynamic). For instance, s3://bucket/73b29fa90d3eac0b1fae403b7583fdd1529942dc/ubuntu16.04/cu92mkl/static/libmxnet.so
+The artifact repository is an S3 bucket accessible only to restricted Jenkins nodes. It is used to store compiled MXNet artifacts that can be used by downstream CD pipelines to package the compiled libraries for different delivery channels (e.g. DockerHub, PyPI, Maven, etc.). The S3 object keys for the files being posted will be prefixed with the following distinguishing characteristics of the binary: branch, commit id, operating system, variant and dependency linking strategy (static or dynamic). For instance, s3://bucket/73b29fa90d3eac0b1fae403b7583fdd1529942dc/ubuntu16.04/cu100mkl/static/libmxnet.so
Review comment:
cu100mkl is not a valid variant anymore, right? Should we switch it to a valid current variant? It's only documentation for jenkins slaves nodes, so probably not essential.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit edited a comment on pull request #19930: [BACKPORT]Enable CUDA 11.0 on nightly + CUDA 11.2 on pip (#19295)(#19764)
Posted by GitBox <gi...@apache.org>.
access2rohit edited a comment on pull request #19930:
URL: https://github.com/apache/incubator-mxnet/pull/19930#issuecomment-786307977
> the base image `nvidia/cuda:11.2-cudnn8-devel-ubuntu16.04` does not exist, so we probably need to try another image
Checked https://hub.docker.com/r/nvidia/cuda `11.2.1-cudnn8-runtime-ubuntu16.04` exists so `nvidia/cuda:11.2.1-cudnn8-runtime-ubuntu16.04` should work
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on pull request #19930: [BACKPORT]Enable CUDA 11.0 on nightly development builds (#19295)
Posted by GitBox <gi...@apache.org>.
access2rohit commented on pull request #19930:
URL: https://github.com/apache/incubator-mxnet/pull/19930#issuecomment-782318423
@waytrue17 @leezu Can you review ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org