[GitHub] [spark] cloud-fan commented on a change in pull request #26773: [SPARK-30126][CORE]sparkContext.addFile and sparkContext.addJar fails when file path contains spaces

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #26773: [SPARK-30126][CORE]sparkContext.addFile and sparkContext.addJar fails when file path contains spaces
URL: https://github.com/apache/spark/pull/26773#discussion_r356128107
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/SparkContext.scala
 ##########
 @@ -1526,7 +1526,7 @@ class SparkContext(config: SparkConf) extends Logging {
   def addFile(path: String, recursive: Boolean): Unit = {
     val uri = new Path(path).toUri
     val schemeCorrectedPath = uri.getScheme match {
 
 Review comment:
   This path string is only used to create a hadoop Path. Let me confirm: can we create hadoop Path with URI directly?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org