You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2014/08/06 00:15:04 UTC

Review Request 24349: Add ContainerInfo and Volumes proto defs

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24349/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Ian Downes.


Repository: mesos-git


Description
-------

Add containerInfo and volumes proto defs.
The new containerInfo will serve as the base Containerizer configuration that future Containerizers (ie: Docker) can extend from.
Also added a new Volume shared option to configure volume mapping in containerizers.


Diffs
-----

  include/mesos/mesos.proto 6d4fd145004a14514e27ba65b2eae19b945aeb83 

Diff: https://reviews.apache.org/r/24349/diff/


Testing
-------

make check


Thanks,

Timothy Chen


Re: Review Request 24349: Add ContainerInfo and Volumes proto defs

Posted by Timothy Chen <tn...@apache.org>.

> On Aug. 7, 2014, 3:10 p.m., Benjamin Hindman wrote:
> > Any reason not to nest Volume in ContainerInfo?

Didn't have a use case so didn't include that. Do you think it makes sense to have that up front? I was thinking a list of volume maps is suffice


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24349/#review49897
-----------------------------------------------------------


On Aug. 6, 2014, 7:21 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24349/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2014, 7:21 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ian Downes.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Add containerInfo and volumes proto defs.
> The new containerInfo will serve as the base Containerizer configuration that future Containerizers (ie: Docker) can extend from.
> Also added a new Volume shared option to configure volume mapping in containerizers.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 628cce1 
> 
> Diff: https://reviews.apache.org/r/24349/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Re: Review Request 24349: Add ContainerInfo and Volumes proto defs

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24349/#review49897
-----------------------------------------------------------

Ship it!


Any reason not to nest Volume in ContainerInfo?


include/mesos/mesos.proto
<https://reviews.apache.org/r/24349/#comment87309>

    s/absolute/Absolute/
    
    Here and below please.


- Benjamin Hindman


On Aug. 6, 2014, 7:21 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24349/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2014, 7:21 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ian Downes.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Add containerInfo and volumes proto defs.
> The new containerInfo will serve as the base Containerizer configuration that future Containerizers (ie: Docker) can extend from.
> Also added a new Volume shared option to configure volume mapping in containerizers.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 628cce1 
> 
> Diff: https://reviews.apache.org/r/24349/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Re: Review Request 24349: Add ContainerInfo and Volumes proto defs

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24349/#review50010
-----------------------------------------------------------


Bad patch!

Reviews applied: [24349]

Failed command: git apply --index 24349.patch

Error:
 error: patch failed: include/mesos/mesos.proto:802
error: include/mesos/mesos.proto: patch does not apply


- Mesos ReviewBot


On Aug. 7, 2014, 6:10 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24349/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2014, 6:10 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ian Downes.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Add ContainerInfo and Volumes proto defs
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 628cce12d2fae645d2ef55e4809631ca03a56207 
> 
> Diff: https://reviews.apache.org/r/24349/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Re: Review Request 24349: Add ContainerInfo and Volumes proto defs

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24349/#review50308
-----------------------------------------------------------


Patch looks great!

Reviews applied: [24349]

All tests passed.

- Mesos ReviewBot


On Aug. 8, 2014, 6:10 a.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24349/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2014, 6:10 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ian Downes.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Review: https://reviews.apache.org/r/24349
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto efb42395f040eb9a9a25fbbb08582460b42a4390 
> 
> Diff: https://reviews.apache.org/r/24349/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Re: Review Request 24349: Add ContainerInfo and Volumes proto defs

Posted by Timothy Chen <tn...@apache.org>.

> On Aug. 8, 2014, 7:33 a.m., Adam B wrote:
> > include/mesos/mesos.proto, line 829
> > <https://reviews.apache.org/r/24349/diff/4/?file=656505#file656505line829>
> >
> >     Why would you ever not have a host path? Or are you imagining that we might eventually support volumes mapping from/to remote or other non-host resources?

Some isolator or containerizer doesn't require it, such as Docker that volume mapping doesn't require a host path, as it then chooses a host directory to map it for you that docker itself manages.


> On Aug. 8, 2014, 7:33 a.m., Adam B wrote:
> > include/mesos/mesos.proto, line 844
> > <https://reviews.apache.org/r/24349/diff/4/?file=656505#file656505line844>
> >
> >     Are we really going to have two different (albeit differently namespaced) ContainerInfo messages?
> >     How about calling this one "ContainerConfig" or "ContainerConfigInfo" since it doesn't even have the container image (like ContainerInfo does), just additional configuration?
> >     How soon can we deprecate the original ContainerInfo?

It's meant to replace the old one, where we keep the old one for now but deprecating it.


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24349/#review50016
-----------------------------------------------------------


On Aug. 8, 2014, 6:10 a.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24349/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2014, 6:10 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ian Downes.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Review: https://reviews.apache.org/r/24349
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto efb42395f040eb9a9a25fbbb08582460b42a4390 
> 
> Diff: https://reviews.apache.org/r/24349/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Re: Review Request 24349: Add ContainerInfo and Volumes proto defs

Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24349/#review50016
-----------------------------------------------------------



include/mesos/mesos.proto
<https://reviews.apache.org/r/24349/#comment87523>

    Why would you ever not have a host path? Or are you imagining that we might eventually support volumes mapping from/to remote or other non-host resources?



include/mesos/mesos.proto
<https://reviews.apache.org/r/24349/#comment87524>

    Are we really going to have two different (albeit differently namespaced) ContainerInfo messages?
    How about calling this one "ContainerConfig" or "ContainerConfigInfo" since it doesn't even have the container image (like ContainerInfo does), just additional configuration?
    How soon can we deprecate the original ContainerInfo?


- Adam B


On Aug. 7, 2014, 11:10 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24349/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2014, 11:10 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ian Downes.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Review: https://reviews.apache.org/r/24349
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto efb42395f040eb9a9a25fbbb08582460b42a4390 
> 
> Diff: https://reviews.apache.org/r/24349/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Re: Review Request 24349: Add ContainerInfo and Volumes proto defs

Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24349/
-----------------------------------------------------------

(Updated Aug. 8, 2014, 6:10 a.m.)


Review request for mesos, Benjamin Hindman and Ian Downes.


Changes
-------

rebased


Repository: mesos-git


Description (updated)
-------

Review: https://reviews.apache.org/r/24349


Diffs (updated)
-----

  include/mesos/mesos.proto efb42395f040eb9a9a25fbbb08582460b42a4390 

Diff: https://reviews.apache.org/r/24349/diff/


Testing
-------

make check


Thanks,

Timothy Chen


Re: Review Request 24349: Add ContainerInfo and Volumes proto defs

Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24349/
-----------------------------------------------------------

(Updated Aug. 7, 2014, 6:10 p.m.)


Review request for mesos, Benjamin Hindman and Ian Downes.


Changes
-------

addressed comments.


Repository: mesos-git


Description (updated)
-------

Add ContainerInfo and Volumes proto defs


Diffs (updated)
-----

  include/mesos/mesos.proto 628cce12d2fae645d2ef55e4809631ca03a56207 

Diff: https://reviews.apache.org/r/24349/diff/


Testing
-------

make check


Thanks,

Timothy Chen


Re: Review Request 24349: Add ContainerInfo and Volumes proto defs

Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24349/
-----------------------------------------------------------

(Updated Aug. 6, 2014, 7:21 p.m.)


Review request for mesos, Benjamin Hindman and Ian Downes.


Repository: mesos-git


Description
-------

Add containerInfo and volumes proto defs.
The new containerInfo will serve as the base Containerizer configuration that future Containerizers (ie: Docker) can extend from.
Also added a new Volume shared option to configure volume mapping in containerizers.


Diffs (updated)
-----

  include/mesos/mesos.proto 628cce1 

Diff: https://reviews.apache.org/r/24349/diff/


Testing
-------

make check


Thanks,

Timothy Chen


Re: Review Request 24349: Add ContainerInfo and Volumes proto defs

Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24349/#review49786
-----------------------------------------------------------

Ship it!



include/mesos/mesos.proto
<https://reviews.apache.org/r/24349/#comment87113>

    s/in/on/



include/mesos/mesos.proto
<https://reviews.apache.org/r/24349/#comment87114>

    perhaps?
    s/a containerizer configuration/a container configuration/


- Ian Downes


On Aug. 5, 2014, 3:15 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24349/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2014, 3:15 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ian Downes.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Add containerInfo and volumes proto defs.
> The new containerInfo will serve as the base Containerizer configuration that future Containerizers (ie: Docker) can extend from.
> Also added a new Volume shared option to configure volume mapping in containerizers.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 6d4fd145004a14514e27ba65b2eae19b945aeb83 
> 
> Diff: https://reviews.apache.org/r/24349/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>