[GitHub] [spark] cloud-fan commented on a change in pull request #34554: [SPARK-37286][SQL] Move compileAggregates from JDBCRDD to JdbcDialect

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #34554:
URL: https://github.com/apache/spark/pull/34554#discussion_r761129237



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala
##########
@@ -193,6 +194,36 @@ abstract class JdbcDialect extends Serializable with Logging{
     case _ => value
   }
 
+  /**
+   * Converts aggregate function to String representing a SQL expression.
+   * @param aggregates The aggregate functions to be converted.
+   * @return Converted value.
+   */
+  @Since("3.3.0")
+  def compileAggregates(aggregates: Seq[AggregateFunc]): Option[Seq[String]] = {

Review comment:
       since this is an API now, shall we make it `def compileAggregates(func:AggregateFunc): Option[String]` so that it's cleaner and easier to implement?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org