[GitHub] [cordova-plugin-splashscreen] janpio commented on issue #180: Android: App exits fullscreen mode when splash is visible

[GitBox <gi...@apache.org>]

janpio commented on issue #180: Android: App exits fullscreen mode when splash is visible
URL: https://github.com/apache/cordova-plugin-splashscreen/issues/180#issuecomment-489447613
 
 
   > 1. `CordovaActivity onCreate:` Cordova reads the "Fullscreen" preference. If true and you haven't also set the "FullscreenNotImmersive" preference, it sets `immersiveMode = true`. However, it never actually calls `setSystemUiVisibility()` to set `FLAG_FULLSCREEN`
   
   That could be considered a bug of `cordova-android`, correct? If so, it would be awesome if you could create a PR over there to fix this!
   
   > Make this plugin read the fullscreen preference instead of relying on `FLAG_FULLSCREEN` being set.
   
   Hmm, the fullscreen-preference is usually not part of that plugin, so this is a bit dirty. But if this fixes the behavior _right now_, I think having it read that **as well additionally** I think we should be fine. Can you create a PR for this as well?
   
   > _EDIT_: Just tried both solutions, and settings the flags in onCreate helped, but the status bar and navigation bar still flash in/out when the app starts. It'd be great if someone with more experience in the codebase could take a look at it.
   
   Not that many people of that around any more, so we have to work with what we got - and in this case you seem to be the expert for this problem @distinctdan - so I would really appreciate it if you could go ahead and suggest some code.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org