You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by "artnaseef (via GitHub)" <gi...@apache.org> on 2025/04/08 16:03:29 UTC
[PR] ARTEMIS-5388 Expose core bridge connection status and via JMX. [activemq-artemis]
artnaseef opened a new pull request, #5613:
URL: https://github.com/apache/activemq-artemis/pull/5613
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-5388 Expose core bridge connection status via JMX [activemq-artemis]
Posted by "artnaseef (via GitHub)" <gi...@apache.org>.
artnaseef commented on code in PR #5613:
URL: https://github.com/apache/activemq-artemis/pull/5613#discussion_r2035743236
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/BridgeControl.java:
##########
@@ -140,4 +140,12 @@ public interface BridgeControl extends ActiveMQComponentControl {
@Attribute(desc = "The metrics for this bridge. The messagesPendingAcknowledgement counter is incremented when the bridge is has forwarded a message but is waiting acknowledgement from the remote broker. The messagesAcknowledged counter is the number of messages actually received by the remote broker.")
Map<String, Object> getMetrics();
+
+ /**
+ * Report the connection state of the bridge.
+ *
+ * {@return whether the bridge is actively connected to the remote broker}
Review Comment:
Ahh thanks - I saw that was used above in the same file, so I was trying to keep it consistent. Honestly, I had never seen that syntax before, and I have no idea what the brackets mean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-5388 Expose core bridge connection status and via JMX. [activemq-artemis]
Posted by "jbertram (via GitHub)" <gi...@apache.org>.
jbertram commented on PR #5613:
URL: https://github.com/apache/activemq-artemis/pull/5613#issuecomment-2787561798
@artnaseef, thanks much for the PR! This is a nice addition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-5388 Expose core bridge connection status and via JMX. [activemq-artemis]
Posted by "jbertram (via GitHub)" <gi...@apache.org>.
jbertram commented on code in PR #5613:
URL: https://github.com/apache/activemq-artemis/pull/5613#discussion_r2033937540
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/BridgeControl.java:
##########
@@ -140,4 +140,12 @@ public interface BridgeControl extends ActiveMQComponentControl {
@Attribute(desc = "The metrics for this bridge. The messagesPendingAcknowledgement counter is incremented when the bridge is has forwarded a message but is waiting acknowledgement from the remote broker. The messagesAcknowledged counter is the number of messages actually received by the remote broker.")
Map<String, Object> getMetrics();
+
+ /**
+ * Report the connection state of the bridge.
+ *
+ * {@return whether the bridge is actively connected to the remote broker}
Review Comment:
I'm going to clean this up a little when I merge it so don't worry about it, @artnaseef.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-5388 Expose core bridge connection status via JMX [activemq-artemis]
Posted by "artnaseef (via GitHub)" <gi...@apache.org>.
artnaseef commented on code in PR #5613:
URL: https://github.com/apache/activemq-artemis/pull/5613#discussion_r2035745494
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/BridgeControl.java:
##########
@@ -140,4 +140,12 @@ public interface BridgeControl extends ActiveMQComponentControl {
@Attribute(desc = "The metrics for this bridge. The messagesPendingAcknowledgement counter is incremented when the bridge is has forwarded a message but is waiting acknowledgement from the remote broker. The messagesAcknowledged counter is the number of messages actually received by the remote broker.")
Map<String, Object> getMetrics();
+
+ /**
+ * Report the connection state of the bridge.
+ *
+ * {@return whether the bridge is actively connected to the remote broker}
Review Comment:
Ahh, I see - the other methods had no description, so then brackets are required to distinguish the javadoc from a regular comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-5388 Expose core bridge connection status and via JMX. [activemq-artemis]
Posted by "asfgit (via GitHub)" <gi...@apache.org>.
asfgit closed pull request #5613: ARTEMIS-5388 Expose core bridge connection status and via JMX.
URL: https://github.com/apache/activemq-artemis/pull/5613
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-5388 Expose core bridge connection status via JMX [activemq-artemis]
Posted by "jbertram (via GitHub)" <gi...@apache.org>.
jbertram commented on code in PR #5613:
URL: https://github.com/apache/activemq-artemis/pull/5613#discussion_r2035762099
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/BridgeControl.java:
##########
@@ -140,4 +140,12 @@ public interface BridgeControl extends ActiveMQComponentControl {
@Attribute(desc = "The metrics for this bridge. The messagesPendingAcknowledgement counter is incremented when the bridge is has forwarded a message but is waiting acknowledgement from the remote broker. The messagesAcknowledged counter is the number of messages actually received by the remote broker.")
Map<String, Object> getMetrics();
+
+ /**
+ * Report the connection state of the bridge.
+ *
+ * {@return whether the bridge is actively connected to the remote broker}
Review Comment:
The `{@return ...}` syntax was [introduced in Java 16](https://bugs.openjdk.org/browse/JDK-8256804). We recently overhauled the code-based to take advantage of it via ARTEMIS-5314.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-5388 Expose core bridge connection status and via JMX. [activemq-artemis]
Posted by "tabish121 (via GitHub)" <gi...@apache.org>.
tabish121 commented on code in PR #5613:
URL: https://github.com/apache/activemq-artemis/pull/5613#discussion_r2033869062
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/BridgeControl.java:
##########
@@ -140,4 +140,12 @@ public interface BridgeControl extends ActiveMQComponentControl {
@Attribute(desc = "The metrics for this bridge. The messagesPendingAcknowledgement counter is incremented when the bridge is has forwarded a message but is waiting acknowledgement from the remote broker. The messagesAcknowledged counter is the number of messages actually received by the remote broker.")
Map<String, Object> getMetrics();
+
+ /**
+ * Report the connection state of the bridge.
+ *
+ * {@return whether the bridge is actively connected to the remote broker}
Review Comment:
You only need to use the bracketed return style if you are omitting the single line heading which you could do here, otherwise the brackets should be omitted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact