You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2013/02/20 21:49:15 UTC

Re: Review Request: Added new test fixture to properly setup and teardown slave working directory

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8055/#review16793
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On Jan. 16, 2013, 2:40 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8055/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2013, 2:40 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Description
> -------
> 
> I envisage this new test fixture to do a lot more than creating/deleting working directories. But thats probably for another review.
> 
> 
> Diffs
> -----
> 
>   src/tests/allocator_tests.cpp 44d72ad2b746b1b7032f8243817a6002100a7503 
>   src/tests/allocator_zookeeper_tests.cpp 5f83dd71aa3cac1dd3727b65af087f651f961392 
>   src/tests/configurator_tests.cpp 91c01ad19c23a3f7b1e0e0c369e8d6d9fa534dc5 
>   src/tests/fault_tolerance_tests.cpp 7c3d155479a4f7fda5c14f62909eea5f5a1a92df 
>   src/tests/master_detector_tests.cpp 5d09babc728d7922e47204290e86943179a34226 
>   src/tests/master_tests.cpp 948ab5dff34eeba1f3ce593a864ddf282c8b19ed 
>   src/tests/resource_offers_tests.cpp 5981191597e673c47be331420b71be66456694c6 
>   src/tests/utils.hpp be457117515ee727af101370b26bf9188afb8f45 
>   src/tests/zookeeper_test.hpp 2aa105fed170b2824040a79bd450129f06c4bc13 
>   src/tests/zookeeper_test.cpp 4bd6a293c177864b8767c876ccd91e7cbb0f84f0 
> 
> Diff: https://reviews.apache.org/r/8055/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>