You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/10/25 09:00:44 UTC

[GitHub] [airflow] ashb commented on a change in pull request #6427: [WIP] dont re-read on heartbeat

ashb commented on a change in pull request #6427: [WIP] dont re-read on heartbeat
URL: https://github.com/apache/airflow/pull/6427#discussion_r338953483
 
 

 ##########
 File path: airflow/jobs/base_job.py
 ##########
 @@ -199,8 +188,9 @@ def heartbeat(self):
                 convert_camel_to_snake(self.__class__.__name__) + '_heartbeat_failure', 1,
                 1)
             self.log.exception("%s heartbeat got an exception", self.__class__.__name__)
-            # We didn't manage to heartbeat, so make sure that the timestamp isn't updated
-            self.latest_heartbeat = previous_heartbeat
 
 Review comment:
   We need to keep this though, see https://issues.apache.org/jira/browse/AIRFLOW-5102

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services