You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beehive.apache.org by "carlin rogers (JIRA)" <be...@incubator.apache.org> on 2005/02/09 00:40:12 UTC
[jira] Created: (BEEHIVE-262) update the JPF declarative validation to support commons validator v1.1
update the JPF declarative validation to support commons validator v1.1
-----------------------------------------------------------------------
Key: BEEHIVE-262
URL: http://issues.apache.org/jira/browse/BEEHIVE-262
Project: Beehive
Type: Task
Components: NetUI
Versions: V1Beta
Reporter: carlin rogers
Assigned to: carlin rogers
Fix For: V1Beta
The current implementation of the NetUI declarative validation only
supports version 1.0 of the commons validator. Need to update the
source and schema to support v1.1.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Updated: (BEEHIVE-262) update the JPF declarative validation to support commons validator v1.1
Posted by "carlin rogers (JIRA)" <be...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-262?page=history ]
carlin rogers updated BEEHIVE-262:
----------------------------------
Attachment: patch.tar.gz
Here's a patch file to use to update the declarative validation
to support commons validator v1.1.
- Updated the validator schema to version 1.1.
- Modified the name of the v1.1 validator package for the
XMLBean classes.
- Implemented new message arg annotation and bundle name
attributes.
- Added a grammar class for the array of message arguments.
- Provided support for the ealier, v1.0 validator that is
part of struts 1.1.
- Created a new test for the message args.
- Fixed Jira bug (BEEHIVE-261) for validation merge feature
and added a test.
> update the JPF declarative validation to support commons validator v1.1
> -----------------------------------------------------------------------
>
> Key: BEEHIVE-262
> URL: http://issues.apache.org/jira/browse/BEEHIVE-262
> Project: Beehive
> Type: Task
> Components: NetUI
> Versions: V1Beta
> Reporter: carlin rogers
> Assignee: carlin rogers
> Fix For: V1Beta
> Attachments: patch.tar.gz
>
> The current implementation of the NetUI declarative validation only
> supports version 1.0 of the commons validator. Need to update the
> source and schema to support v1.1.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Updated: (BEEHIVE-262) update the JPF declarative validation to support commons validator v1.1
Posted by "carlin rogers (JIRA)" <be...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-262?page=history ]
carlin rogers updated BEEHIVE-262:
----------------------------------
Attachment: val_patch.txt
Rich, here's another patch to address the improvements you mentioned
as well as some additional error condition checking on the use of
bundles. Let me know if you have some more thoughts. Thanks.
- Modified BaseValidationRuleGrammar to check an for argument at
position 0 in the MessageArgs before adding the
using-default-display-name warning.
- Changed the definition for @Jpf.MessageArg such that position()
is optional and defaults to -1.
- Added a new BundleNameType to ensure that the bundle attribute
for messages and args is used with versions of commons-validator
more recent than v1.0.
> update the JPF declarative validation to support commons validator v1.1
> -----------------------------------------------------------------------
>
> Key: BEEHIVE-262
> URL: http://issues.apache.org/jira/browse/BEEHIVE-262
> Project: Beehive
> Type: Task
> Components: NetUI
> Versions: V1Beta
> Reporter: carlin rogers
> Assignee: carlin rogers
> Fix For: V1Beta
> Attachments: patch.tar.gz, patch.tar.gz, val_patch.txt
>
> The current implementation of the NetUI declarative validation only
> supports version 1.0 of the commons validator. Need to update the
> source and schema to support v1.1.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Closed: (BEEHIVE-262) update the JPF declarative validation to support commons validator v1.1
Posted by "Alejandro Ramirez (JIRA)" <be...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-262?page=all ]
Alejandro Ramirez closed BEEHIVE-262:
-------------------------------------
Verified Fixed. The following coreWeb tests are passing as of svn rev: 170231
- ValidateCustom
- ValidationDefaultMessages
- ValidatorMerge
- ValidatorMerge11
- ValidatorMsgArgs
- ValidatorMsgArgs11
> update the JPF declarative validation to support commons validator v1.1
> -----------------------------------------------------------------------
>
> Key: BEEHIVE-262
> URL: http://issues.apache.org/jira/browse/BEEHIVE-262
> Project: Beehive
> Type: Task
> Components: NetUI
> Versions: V1Beta
> Reporter: Carlin Rogers
> Assignee: Alejandro Ramirez
> Fix For: V1Beta
> Attachments: patch.tar.gz, patch.tar.gz, val_patch.txt
>
> The current implementation of the NetUI declarative validation only
> supports version 1.0 of the commons validator. Need to update the
> source and schema to support v1.1.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (BEEHIVE-262) update the JPF declarative validation to support commons validator v1.1
Posted by "Rich Feit (JIRA)" <be...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-262?page=comments#action_59179 ]
Rich Feit commented on BEEHIVE-262:
-----------------------------------
Forgot to mention: the failing Struts 1.1 DRTs were due to http://issues.apache.org/jira/browse/BEEHIVE-296 , which I fixed earlier today. Thanks for the heads-up on that.
> update the JPF declarative validation to support commons validator v1.1
> -----------------------------------------------------------------------
>
> Key: BEEHIVE-262
> URL: http://issues.apache.org/jira/browse/BEEHIVE-262
> Project: Beehive
> Type: Task
> Components: NetUI
> Versions: V1Beta
> Reporter: carlin rogers
> Assignee: carlin rogers
> Fix For: V1Beta
> Attachments: patch.tar.gz, patch.tar.gz
>
> The current implementation of the NetUI declarative validation only
> supports version 1.0 of the commons validator. Need to update the
> source and schema to support v1.1.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Assigned: (BEEHIVE-262) update the JPF declarative validation to support commons validator v1.1
Posted by "carlin rogers (JIRA)" <be...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-262?page=history ]
carlin rogers reassigned BEEHIVE-262:
-------------------------------------
Assign To: Rich Feit (was: carlin rogers)
> update the JPF declarative validation to support commons validator v1.1
> -----------------------------------------------------------------------
>
> Key: BEEHIVE-262
> URL: http://issues.apache.org/jira/browse/BEEHIVE-262
> Project: Beehive
> Type: Task
> Components: NetUI
> Versions: V1Beta
> Reporter: carlin rogers
> Assignee: Rich Feit
> Fix For: V1Beta
> Attachments: patch.tar.gz, patch.tar.gz, val_patch.txt
>
> The current implementation of the NetUI declarative validation only
> supports version 1.0 of the commons validator. Need to update the
> source and schema to support v1.1.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
Re: [jira] Assigned: (BEEHIVE-262) update the JPF declarative validation
to support commons validator v1.1
Posted by Carlin Rogers <ca...@bea.com>.
Rich,
Thanks for the code check in and for the comments. I think you're right
on both comments. I forgot to change the Jpf.MessageArg interface after
decision to use an implied position rather than require it. I can make
both those changes and add another patch here.
Thanks,
Carlin
Rich Feit (JIRA) wrote:
> [ http://issues.apache.org/jira/browse/BEEHIVE-262?page=history ]
>
> Rich Feit reassigned BEEHIVE-262:
> ---------------------------------
>
> Assign To: carlin rogers (was: Rich Feit)
>
> Hey Carlin, I submitted this patch (thanks!). I have two questions for you before we close out this issue:
>
> 1) In BaseValidationRuleGrammar, you removed the following two lines from the condition for adding the using-default-display-name warning.
> < && CompilerUtils.getString( annotation, ARG0_ATTR, true ) == null
> < && CompilerUtils.getString( annotation, ARG0_KEY_ATTR, true ) == null
> I think this means that we'll always get the warning, even when there *is* an argument at position 0. Shouldn't this condition be replaced with logic that goes against the array of MessageArg annotations?
>
> 2) Also, in GenValidationModel.java, you've got code for inferring the position from the position in the array (which I support). But in the definition for @Jpf.MessageArg (in Jpf.java), position() is required. I think it should instead default to -1, which should make your code in GenValidationModel work unchanged. What do you think?
>
>
>
>
>
>>update the JPF declarative validation to support commons validator v1.1
>>-----------------------------------------------------------------------
>>
>> Key: BEEHIVE-262
>> URL: http://issues.apache.org/jira/browse/BEEHIVE-262
>> Project: Beehive
>> Type: Task
>> Components: NetUI
>> Versions: V1Beta
>> Reporter: carlin rogers
>> Assignee: carlin rogers
>> Fix For: V1Beta
>> Attachments: patch.tar.gz, patch.tar.gz
>>
>>The current implementation of the NetUI declarative validation only
>>supports version 1.0 of the commons validator. Need to update the
>>source and schema to support v1.1.
>
>
[jira] Assigned: (BEEHIVE-262) update the JPF declarative validation to support commons validator v1.1
Posted by "Rich Feit (JIRA)" <be...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-262?page=history ]
Rich Feit reassigned BEEHIVE-262:
---------------------------------
Assign To: carlin rogers (was: Rich Feit)
Hey Carlin, I submitted this patch (thanks!). I have two questions for you before we close out this issue:
1) In BaseValidationRuleGrammar, you removed the following two lines from the condition for adding the using-default-display-name warning.
< && CompilerUtils.getString( annotation, ARG0_ATTR, true ) == null
< && CompilerUtils.getString( annotation, ARG0_KEY_ATTR, true ) == null
I think this means that we'll always get the warning, even when there *is* an argument at position 0. Shouldn't this condition be replaced with logic that goes against the array of MessageArg annotations?
2) Also, in GenValidationModel.java, you've got code for inferring the position from the position in the array (which I support). But in the definition for @Jpf.MessageArg (in Jpf.java), position() is required. I think it should instead default to -1, which should make your code in GenValidationModel work unchanged. What do you think?
> update the JPF declarative validation to support commons validator v1.1
> -----------------------------------------------------------------------
>
> Key: BEEHIVE-262
> URL: http://issues.apache.org/jira/browse/BEEHIVE-262
> Project: Beehive
> Type: Task
> Components: NetUI
> Versions: V1Beta
> Reporter: carlin rogers
> Assignee: carlin rogers
> Fix For: V1Beta
> Attachments: patch.tar.gz, patch.tar.gz
>
> The current implementation of the NetUI declarative validation only
> supports version 1.0 of the commons validator. Need to update the
> source and schema to support v1.1.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Assigned: (BEEHIVE-262) update the JPF declarative validation to support commons validator v1.1
Posted by "carlin rogers (JIRA)" <be...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-262?page=history ]
carlin rogers reassigned BEEHIVE-262:
-------------------------------------
Assign To: Rich Feit (was: carlin rogers)
Assigning to Rich for review and commit.
In testing in the Struts 1.1 (validator 1.0) env I noticed
that there are two validator tests failing. The tests are
ValidateCustom and ValidationDefaultMessages. They were
failing before these changes. I will go bck and see why
the two tests fail in Struts 1.1.
Thanks, Carlin
> update the JPF declarative validation to support commons validator v1.1
> -----------------------------------------------------------------------
>
> Key: BEEHIVE-262
> URL: http://issues.apache.org/jira/browse/BEEHIVE-262
> Project: Beehive
> Type: Task
> Components: NetUI
> Versions: V1Beta
> Reporter: carlin rogers
> Assignee: Rich Feit
> Fix For: V1Beta
> Attachments: patch.tar.gz, patch.tar.gz
>
> The current implementation of the NetUI declarative validation only
> supports version 1.0 of the commons validator. Need to update the
> source and schema to support v1.1.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Updated: (BEEHIVE-262) update the JPF declarative validation to support commons validator v1.1
Posted by "carlin rogers (JIRA)" <be...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-262?page=history ]
carlin rogers updated BEEHIVE-262:
----------------------------------
Attachment: patch.tar.gz
chaned the default behavior to generate validator v1.0 XML unless
version 1.1 is explicitly set with the validatorVersion attribute
on the Controller annotation.
I'm attaching an updated patch with this change plus two additional
tests for validator 1.1.
Please ignore the previous patch.
> update the JPF declarative validation to support commons validator v1.1
> -----------------------------------------------------------------------
>
> Key: BEEHIVE-262
> URL: http://issues.apache.org/jira/browse/BEEHIVE-262
> Project: Beehive
> Type: Task
> Components: NetUI
> Versions: V1Beta
> Reporter: carlin rogers
> Assignee: carlin rogers
> Fix For: V1Beta
> Attachments: patch.tar.gz, patch.tar.gz
>
> The current implementation of the NetUI declarative validation only
> supports version 1.0 of the commons validator. Need to update the
> source and schema to support v1.1.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Resolved: (BEEHIVE-262) update the JPF declarative validation to support commons validator v1.1
Posted by "Rich Feit (JIRA)" <be...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-262?page=history ]
Rich Feit resolved BEEHIVE-262:
-------------------------------
Assign To: Alejandro Ramirez (was: Rich Feit)
Resolution: Fixed
Fixed with revision 154962.
> update the JPF declarative validation to support commons validator v1.1
> -----------------------------------------------------------------------
>
> Key: BEEHIVE-262
> URL: http://issues.apache.org/jira/browse/BEEHIVE-262
> Project: Beehive
> Type: Task
> Components: NetUI
> Versions: V1Beta
> Reporter: Carlin Rogers
> Assignee: Alejandro Ramirez
> Fix For: V1Beta
> Attachments: patch.tar.gz, patch.tar.gz, val_patch.txt
>
> The current implementation of the NetUI declarative validation only
> supports version 1.0 of the commons validator. Need to update the
> source and schema to support v1.1.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira