[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2905: Adding declarative Java hints to the LSP server.

[GitBox <gi...@apache.org>]

JaroslavTulach commented on a change in pull request #2905:
URL: https://github.com/apache/netbeans/pull/2905#discussion_r615612191



##########
File path: java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/protocol/TextDocumentServiceImpl.java
##########
@@ -1569,29 +1567,18 @@ private void runDiagnoticTasks(String uri) {
         //XXX: cancelling/deferring the tasks!
         diagnosticTasks.computeIfAbsent(uri, u -> {
             return BACKGROUND_TASKS.create(() -> {
-                computeDiags(u, (info, doc) -> {
-                    ErrorHintsProvider ehp = new ErrorHintsProvider();
-                    return ehp.computeErrors(info, doc, "text/x-java"); //TODO: mimetype?
-                }, "errors", false);
+                System.err.println("computing diags for: " + uri + ", errors");

Review comment:
       Forgotten `println`.

##########
File path: ide/api.lsp/nbproject/project.xml
##########
@@ -52,6 +52,15 @@
                         <specification-version>1.77</specification-version>
                     </run-dependency>
                 </dependency>
+                <dependency>
+                    <code-name-base>org.netbeans.spi.editor.hints</code-name-base>

Review comment:
       This dependency is increasing [weight of the api.lsp module](http://wiki.apidesign.org/wiki/HeavyWeight). How much? I see five editor related libraries. Can such additional height be avoided?
   
   I lived under the impression that the goal of LSP isn't to expose NetBeans Editor API, but rather abstract away from it. Bringing these libraries here via transitive dependencies seems to go against such goal.
   
   @dbalek - right now there is one dependency on editor API in the `api.lsp` module - but hopefully it could be removed by replacing it with direct call to `(String)doc.getProperty("mimeType")`.
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists