You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2015/04/25 00:38:38 UTC
[jira] [Commented] (SOLR-7469) check-licenses happily ignoring
incorrect start.jar.sha1, current start.jar.sha1 on trunk is out of date.
[ https://issues.apache.org/jira/browse/SOLR-7469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14511923#comment-14511923 ]
ASF subversion and git services commented on SOLR-7469:
-------------------------------------------------------
Commit 1675968 from hossman@apache.org in branch 'dev/trunk'
[ https://svn.apache.org/r1675968 ]
SOLR-7469: Fix check-licenses to accurately detect if start.jar.sha1 is incorrect
> check-licenses happily ignoring incorrect start.jar.sha1, current start.jar.sha1 on trunk is out of date.
> ---------------------------------------------------------------------------------------------------------
>
> Key: SOLR-7469
> URL: https://issues.apache.org/jira/browse/SOLR-7469
> Project: Solr
> Issue Type: Task
> Reporter: Hoss Man
> Assignee: Hoss Man
> Priority: Blocker
> Fix For: 5.2
>
> Attachments: SOLR-7469.patch
>
>
> as of r1675948, "ant clean jar-checksums" results in a modified solr/licenses/start.jar.sha1 ...
> {noformat}
> hossman@frisbee:~/lucene/dev$ svn diff
> Index: solr/licenses/start.jar.sha1
> ===================================================================
> --- solr/licenses/start.jar.sha1 (revision 1675948)
> +++ solr/licenses/start.jar.sha1 (working copy)
> @@ -1 +1 @@
> -24e798bde886e1430978ece6c4aa90d781e2da30
> +b91b72f9167cce4c1caea0f8363fd9984456e34d
> {noformat}
> ...so apparently the version of start.jar we're fetching from ivy & using in solr changed at some point w/o the SHA1 being updated?
> apparently because "check-licenses" is explicitly ignoring start.jar...
> {noformat}
> <!-- Exclude start.jar only (it'd be weird to have a license file there?) -->
> <exclude name="server/start.jar" />
> {noformat}
> ...this is seriously messed up. we need to fix this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org