Re: cvs commit: apr/file_io/unix mktemp.c

[Cliff Woolley <cl...@yahoo.com>]

On 6 Oct 2001 jwoolley@apache.org wrote:

> jwoolley    01/10/06 14:31:10
>
>   Modified:    .        CHANGES
>                file_io/unix mktemp.c
>   Log:
>   Many fixes to apr_file_mktemp when !HAVE_MKSTEMP to (a) make it work
>   and (b) be consistent with systems that do have mkstemp.
>
>    - s/APR_HAS_STDINT_H/APR_HAVE_STDINT_H/
>    - dropped use of errno and just returned the apr status directly
>    - fixed gettemp prototype to allow the apr_file_t* to actually be returned
>    - set missing APR_DELONCLOSE flag in call to apr_file_open in gettemp
>    - removed duplicate calls to apr_pool_cleanup_register for platforms that
>      use gettemp because apr_file_open() already registers the cleanup for us
>    - dropped support for a NULL apr_file_t** parameter (which only worked
>      if !HAVE_MKSTEMP anyway) because using a temp filename that has been
>      created that way is unsafe.

Oops, left one off the list:

     - removed unused domkdir functionality from gettemp

--Cliff

--------------------------------------------------------------
   Cliff Woolley
   cliffwoolley@yahoo.com
   Charlottesville, VA