You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@aurora.apache.org by "John Sirois (JIRA)" <ji...@apache.org> on 2016/01/26 20:58:39 UTC
[jira] [Commented] (AURORA-1599) HealthCheckerConfig should
validate it has only 1 set field
[ https://issues.apache.org/jira/browse/AURORA-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117868#comment-15117868 ]
John Sirois commented on AURORA-1599:
-------------------------------------
Noting that this could either be done in XXX where other high-level validations are performed, or else a Union type could be introduced to pystachion such that we could just write a {{Job}} schema like:
{noformat}
DefaultHealthChecker = HttpHealthChecker()
class Job(Struct):
health_check_config = Default(Union(HttpHealthChecker, ShellHealthChecker), DefaultHealthChecker)
...
{noformat}
> HealthCheckerConfig should validate it has only 1 set field
> -----------------------------------------------------------
>
> Key: AURORA-1599
> URL: https://issues.apache.org/jira/browse/AURORA-1599
> Project: Aurora
> Issue Type: Story
> Components: Client
> Reporter: John Sirois
> Priority: Minor
>
> As discussed in https://reviews.apache.org/r/42816/ - the {{HealthCheckerConfig}} struct has 2 fields, but these 2 fields are treated like a union today behind the scenes. This union-style treatment is silent - we check for a {{shell}} 1st and use it and ignore {{http}} if also populated. This could lead to user confusion. It would be better to fail fast if both types of health check are configured.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)