[GitHub] [nifi-minifi-cpp] bakaid commented on pull request #774: MINIFICPP-1208 - Enable rocksdb tools build

[GitBox <gi...@apache.org>]

bakaid commented on pull request #774:
URL: https://github.com/apache/nifi-minifi-cpp/pull/774#issuecomment-620763467


   The binaries can be found in the `thirdparty/rocksdb-install/bin/` directory in your build dir.
   If by `make install` you mean `make package`, I think the should definitely not be included in our final distribution for two reasons:
    - it is confusing to the users
    - the binaries are quite large:
   ```
   $ ls -lh thirdparty/rocksdb-install/bin/
   total 30352
   -rwxr-xr-x  1 danielbakai  staff    13K Apr 28 14:26 db_repl_stress
   -rwxr-xr-x  1 danielbakai  staff   4.4M Apr 28 14:27 db_sanity_test
   -rwxr-xr-x  1 danielbakai  staff    13K Apr 28 14:27 db_stress
   -rwxr-xr-x  1 danielbakai  staff   5.2M Apr 28 14:27 ldb
   -rwxr-xr-x  1 danielbakai  staff    13K Apr 28 14:27 rocksdb_dump
   -rwxr-xr-x  1 danielbakai  staff    13K Apr 28 14:26 rocksdb_undump
   -rwxr-xr-x  1 danielbakai  staff   5.2M Apr 28 14:27 sst_dump
   -rwxr-xr-x  1 danielbakai  staff    13K Apr 28 14:27 write_stress```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org