You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/12/07 18:56:54 UTC

[GitHub] [hbase] saintstack commented on a change in pull request #2741: HBASE-25364 Redo the getMidPoint() in HFileWriterImpl to get rid of t…

saintstack commented on a change in pull request #2741:
URL: https://github.com/apache/hbase/pull/2741#discussion_r537740722



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterImpl.java
##########
@@ -366,8 +366,6 @@ private void finishBlock() throws IOException {
    */
   public static Cell getMidpoint(final CellComparator comparator, final Cell left,
       final Cell right) {
-    // TODO: Redo so only a single pass over the arrays rather than one to

Review comment:
       From HBASE-10800 ... By our Ramkrishna




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org