You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by David Chen <dc...@linkedin.com> on 2014/07/21 13:19:46 UTC

Review Request 23730: HIVE-7457: Minor HCatalog Pig Adapter test cleanup.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23730/
-----------------------------------------------------------

Review request for hive.


Bugs: HIVE-7457
    https://issues.apache.org/jira/browse/HIVE-7457


Repository: hive-git


Description
-------

HIVE-7457: Minor HCatalog Pig Adapter test cleanup.


Diffs
-----

  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/HCatStorerWrapper.java b06e9b4c35b0c10ed64ea0f7766be2b77fa5bb71 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/MockLoader.java c87b95a00af03d2531eb8bbdda4e307c3aac1fe2 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/MyPigStorage.java d056910cf166d4e22200b8431e235b862e9b3e69 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestE2EScenarios.java a4b55c8463b3563f1e602ae2d0809dd318bcfa7f 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatLoader.java 82fc8a9391667138780be8796931793661f61ebb 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatLoaderComplexSchema.java eadbf20afc525dd9f33e9e7fb2a5d5cb89907d7e 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatLoaderStorer.java 716258458fc27aadaa03918164dba0b49738ed40 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatStorer.java fcfc6428e7db80b8bfe0ce10e37d7b0ee6e58e20 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatStorerMulti.java 76080f7635548ed9af114c823180d8da9ea8f6c2 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatStorerWrapper.java 7f0bca763eb07db3822c6d6028357e81278803c9 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestOrcHCatLoader.java 82eb0d72b4f885184c094113f775415c06bdce98 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestOrcHCatPigStorer.java a9b452101c15fb7a3f0d8d0339f7d0ad97383441 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestOrcHCatStorer.java 1084092828a9ac5e37f5b50b9c6bbd03f70b48fd 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestPigHCatUtil.java a8ce61aaad42b03e4de346530d0724f3d69776b9 

Diff: https://reviews.apache.org/r/23730/diff/


Testing
-------


Thanks,

David Chen

Re: Review Request 23730: HIVE-7457: Minor HCatalog Pig Adapter test clean up.

Posted by David Chen <dc...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23730/
-----------------------------------------------------------

(Updated July 23, 2014, 12:56 a.m.)


Review request for hive.


Changes
-------

Remove style changes.


Summary (updated)
-----------------

HIVE-7457: Minor HCatalog Pig Adapter test clean up.


Bugs: HIVE-7457
    https://issues.apache.org/jira/browse/HIVE-7457


Repository: hive-git


Description (updated)
-------

HIVE-7457: Minor HCatalog Pig Adapter test clean up.


Diffs (updated)
-----

  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/MockLoader.java c87b95a00af03d2531eb8bbdda4e307c3aac1fe2 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestE2EScenarios.java a4b55c8463b3563f1e602ae2d0809dd318bcfa7f 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatLoader.java 82fc8a9391667138780be8796931793661f61ebb 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatLoaderComplexSchema.java eadbf20afc525dd9f33e9e7fb2a5d5cb89907d7e 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatStorer.java fcfc6428e7db80b8bfe0ce10e37d7b0ee6e58e20 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatStorerMulti.java 76080f7635548ed9af114c823180d8da9ea8f6c2 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatStorerWrapper.java 7f0bca763eb07db3822c6d6028357e81278803c9 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestOrcHCatPigStorer.java a9b452101c15fb7a3f0d8d0339f7d0ad97383441 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestOrcHCatStorer.java 1084092828a9ac5e37f5b50b9c6bbd03f70b48fd 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestPigHCatUtil.java a8ce61aaad42b03e4de346530d0724f3d69776b9 

Diff: https://reviews.apache.org/r/23730/diff/


Testing
-------


Thanks,

David Chen

Re: Review Request 23730: HIVE-7457: Minor HCatalog Pig Adapter test cleanup.

Posted by David Chen <dc...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23730/
-----------------------------------------------------------

(Updated July 21, 2014, 11:27 a.m.)


Review request for hive.


Changes
-------

Fix some mangled comments.


Bugs: HIVE-7457
    https://issues.apache.org/jira/browse/HIVE-7457


Repository: hive-git


Description
-------

HIVE-7457: Minor HCatalog Pig Adapter test cleanup.


Diffs (updated)
-----

  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/HCatStorerWrapper.java b06e9b4c35b0c10ed64ea0f7766be2b77fa5bb71 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/MockLoader.java c87b95a00af03d2531eb8bbdda4e307c3aac1fe2 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/MyPigStorage.java d056910cf166d4e22200b8431e235b862e9b3e69 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestE2EScenarios.java a4b55c8463b3563f1e602ae2d0809dd318bcfa7f 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatLoader.java 82fc8a9391667138780be8796931793661f61ebb 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatLoaderComplexSchema.java eadbf20afc525dd9f33e9e7fb2a5d5cb89907d7e 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatLoaderStorer.java 716258458fc27aadaa03918164dba0b49738ed40 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatStorer.java fcfc6428e7db80b8bfe0ce10e37d7b0ee6e58e20 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatStorerMulti.java 76080f7635548ed9af114c823180d8da9ea8f6c2 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatStorerWrapper.java 7f0bca763eb07db3822c6d6028357e81278803c9 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestOrcHCatLoader.java 82eb0d72b4f885184c094113f775415c06bdce98 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestOrcHCatPigStorer.java a9b452101c15fb7a3f0d8d0339f7d0ad97383441 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestOrcHCatStorer.java 1084092828a9ac5e37f5b50b9c6bbd03f70b48fd 
  hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestPigHCatUtil.java a8ce61aaad42b03e4de346530d0724f3d69776b9 

Diff: https://reviews.apache.org/r/23730/diff/


Testing
-------


Thanks,

David Chen