You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/07/10 02:20:42 UTC
[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #1382: checkrelease.sh script now tries to build sim:nsh
adamfeuer commented on a change in pull request #1382:
URL: https://github.com/apache/incubator-nuttx/pull/1382#discussion_r452587085
##########
File path: tools/checkrelease.sh
##########
@@ -19,114 +19,218 @@
#
#############################################################################
-set -e
-
+VERBOSE=0
+RETURN_CODE=0
BASE_URL="https://dist.apache.org/repos/dist/dev/incubator/nuttx"
-TEMPDIR="dist.apache.org"
+DIST_DIR="dist.apache.org"
+TMP="/tmp"
+TEMPDIR="$TMP/nuttx-checkrelease"
ORIGINAL_DIR="$(pwd)"
trap "{ cd $ORIGINAL_DIR; rm -rf $TEMPDIR; }" EXIT
Review comment:
@xiaoxiang781216 will fix
##########
File path: tools/checkrelease.sh
##########
@@ -19,114 +19,218 @@
#
#############################################################################
-set -e
-
+VERBOSE=0
+RETURN_CODE=0
BASE_URL="https://dist.apache.org/repos/dist/dev/incubator/nuttx"
-TEMPDIR="dist.apache.org"
+DIST_DIR="dist.apache.org"
+TMP="/tmp"
+TEMPDIR="$TMP/nuttx-checkrelease"
Review comment:
@xiaoxiang781216 will fix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org